fix(icons): changed flashlight icons
#3843
Conversation
Arcified ends and adjusted the tapering
Update to match `flashlight.svg`
Added attribution and tags
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "csandman", | ||
| "jamiemlaw" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Suggestions for the flashlight-off icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "off", | |
| "dark", | |
| "power", | |
| "mute", | |
| "disable", | |
| "shade", | |
| "night", | |
| "energy", | |
| "inactive", |
| "ericfennis", | ||
| "jamiemlaw" | ||
| ], | ||
| "tags": [ |
There was a problem hiding this comment.
Suggestions for the flashlight icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
| "tags": [ | |
| "tags": [ | |
| "bulb", | |
| "electricity", | |
| "illumination", | |
| "lamp", | |
| "guide", | |
| "visibility", | |
| "shine", |
Added or changed iconsPreview cohesion      Preview stroke widths    DPI Preview16px (shadcn/ui) 
24px (default) 
32px (shadcn/ui + retina) 
48px (default + retina) 
Icon X-rays 
Icon Diffs 
Icons as codeWorks for: const FlashlightOffIcon = createLucideIcon('FlashlightOff', [
["path",{"d":"M11.652 6H18"}],
["path",{"d":"M12 13v1"}],
["path",{"d":"M16 16v4a2 2 0 0 1-2 2h-4a2 2 0 0 1-2-2v-8a4 4 0 0 0-.8-2.4l-.6-.8A3 3 0 0 1 6 7V6"}],
["path",{"d":"m2 2 20 20"}],
["path",{"d":"M7.649 2H17a1 1 0 0 1 1 1v4a3 3 0 0 1-.6 1.8l-.6.8a4 4 0 0 0-.55 1.007"}]
])
const FlashlightIcon = createLucideIcon('Flashlight', [
["path",{"d":"M12 13v1"}],
["path",{"d":"M17 2a1 1 0 0 1 1 1v4a3 3 0 0 1-.6 1.8l-.6.8A4 4 0 0 0 16 12v8a2 2 0 0 1-2 2H10a2 2 0 0 1-2-2v-8a4 4 0 0 0-.8-2.4l-.6-.8A3 3 0 0 1 6 7V3a1 1 0 0 1 1-1z"}],
["path",{"d":"M6 6h12"}]
]) |
|
Nice work, @jamiemlaw, this is overall definitely an improvement, except: I'm not 100% sure, but maybe we should keep the bottom corner radii at 2px. 🤔 I'm also fine with the original, but the rounded versions feel more familiar, I guess. 
|
Correctly round bottom corners
|
@karsa-mistmere Oh, 100% agree. I think that was more an oversight on my part than anything else. Updated without question. I went with the rounded bottom but not the rounded top, but I'm on the fence. Give me a few minutes to decide! |
karsa-mistmere
left a comment
karsa-mistmere
left a comment
There was a problem hiding this comment.
@karsa-mistmere Oh, 100% agree. I think that was more an oversight on my part than anything else. Updated without question.
I went with the rounded bottom but not the rounded top, but I'm on the fence. Give me a few minutes to decide!
Yeah, I also can't really decide between the two. 😄
But I'm also fine with either, so...
|
I'm sticking with the 1px rounding on the top. |
* Update flashlight.svg Arcified ends and adjusted the tapering * Update flashlight-off.svg Update to match `flashlight.svg` * Update flashlight.json Added attribution and tags * Update flashlight-off.json * Update flashlight.svg Correctly round bottom corners * Update flashlight-off.svg
4 participants
Description
Arcifies the top corners of the
flashlighticon, adjusts the tapering to use arcs instead of beziers, and increases the length of the on/off button.And added some extra tags for good measure.
Before Submitting