-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added fishing-hook icon
#3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Added or changed iconsIcons as codeWorks for: const FishingHookIcon = createLucideIcon('FishingHook', [
["path",{"d":"m17.586 11.414-5.93 5.93a1 1 0 0 1-8-8l3.137-3.137a.707.707 0 0 1 1.207.5V10"}],
["path",{"d":"M20.414 8.586 22 7"}],
["circle",{"cx":"19","cy":"10","r":"2"}]
]) |
|
Rotated: |
nice! agree |
Thank you! looks great. |
I'm in favour of using a diagonal, especially since it works super well with the envelope @jamiemlaw designed, but:
|
|
This was the design of just the diagonal fish-hook I had in my scratchpad: Given that the barb is supposed to be pointy, I've applied minimal rounding to it—just enough, IMO. |
upd, Big thanks to @jguddas, @karsa-mistmere and @jamiemlaw
+ contributors
ericfennis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Shouldn’t the tip of the hook be sharper and match the sharper tips of the recently updated anchor icon? The rounded hook just doesn’t resemble real-life hooks very well. |
* Added icons/fishing-hook.svg * Added icons/fishing-hook.json * Update icons/fishing-hook.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update fishing-hook.svg upd, Big thanks to @jguddas, @karsa-mistmere and @jamiemlaw * Update fishing-hook.json + contributors --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eric Fennis <[email protected]>
What is the purpose of this pull request?
Description
Added new
fishing-hookicon.Icon use case
Can be used in categories: fishing, sport, hobby
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting