-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added estimated-weight icon
#3822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added estimated-weight icon
#3822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Added or changed iconsIcons as codeWorks for: const WeightTildeIcon = createLucideIcon('WeightTilde', [
["path",{"d":"M6.5 8a2 2 0 0 0-1.906 1.46L2.1 18.5A2 2 0 0 0 4 21h16a2 2 0 0 0 1.925-2.54L19.4 9.5A2 2 0 0 0 17.48 8z"}],
["path",{"d":"M7.999 15a2.5 2.5 0 0 1 4 0 2.5 2.5 0 0 0 4 0"}],
["circle",{"cx":"12","cy":"5","r":"3"}]
]) |
karsa-mistmere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nathan-de-pachtere,
Nice idea, I think the tilde version works much-much better, but:
- the name should be
weight-estimate - the tilde itself is .5px off-grid, making it rather blurry at 1px, I think we need to decrease the height by 1px to make it perfectly grid-aligned and crisp at 1px
|
Of course I forgot this part 🤦♂️, but also up for debate is whether the name should be |
Changed 💪 |
removed weight and tilde, since they're part of the name
* Added icons/estimated-weight.svg * Added icons/estimated-weight.json * Update icons/estimated-weight.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Change name + reshape tilde * Change name to weight-tilde * Update weight-tilde.json removed weight and tilde, since they're part of the name --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Karsa <[email protected]>

What is the purpose of this pull request?
Description
Added new
estimated-weighticon.Icon use case
« Differentiate a package’s estimated weight from its actual weight. For example, in a factory, we estimate the weight of a package based on the items it contains, and then we weigh the package before transit to determine the exact weight.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting