-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added circle-pile icon
#3681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added circle-pile icon
#3681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
Added or changed iconsIcons as codeWorks for: const CirclePileIcon = createLucideIcon('CirclePile', [
["circle",{"cx":"12","cy":"19","r":"2"}],
["circle",{"cx":"12","cy":"5","r":"2"}],
["circle",{"cx":"16","cy":"12","r":"2"}],
["circle",{"cx":"20","cy":"19","r":"2"}],
["circle",{"cx":"4","cy":"19","r":"2"}],
["circle",{"cx":"8","cy":"12","r":"2"}]
]) |
ericfennis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a more detailed usecase, instead of describing the image?
|
When you want to represent a pile/stack of bars from the side (multiple elements) vs only one with the circle icon. In metallurgy industry we have package that transit through the factory and our software show directly if the packages contains only one or if it's multiple elements. |
|
@nathan-de-pachtere Thanks for the additional information. Sounds like a good usecase! |
|
@ericfennis I'm actually questioning the benefit of my new icons, since we can build the same pattern by using the circle icon five times inside a CSS grid/flex. That way, people can do whatever they want — stack them slightly to the right or left, color one circle, rotate them, change the size, etc. This just increases the library size. I also submitted this one: square-pile, but after that people will start asking for triangles, hexagons, and so on... Wouldn't it be better to have an example of composable icons to cover this use case? Others examples , like The benefit would be a cleaner icon search, fewer choices, and a smaller library size. For example, in our codebase, we wrap every icon in a Vue.js component so that we can swap or use multiple libraries and improve maintainability. That way, we could simply create an IconSquarePile.vue component like this: <template>
<div class="grid ..."> // just example
<Circle> //From lucide icons
<Circle>
<Circle>
<Circle>
<Circle>
<div>
</template>What do you think ? Should I open a subject in discussion for that approach ? |
|
Hmm, yeah, good point. |
ericfennis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
|
I don't like that it is so tall, but every other variant would sacrifice sharpness :/ |
What do you mean by |
|
@nathan-de-pachtere Reducing the height, the pile will look more realistic. But I think reducing the horizontal gaps will result in gap violation or no grid alignment, right? |
@ericfennis and @jguddas Here with the gap squeezed to maximum, will reduce readability at smaller scales
|
|
@nathan-de-pachtere Nice! |
karsa-mistmere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added icons/circle-pile.svg * Added icons/circle-pile.json * Add tags * Reduce high


What is the purpose of this pull request?
Description
Added new
circle-pileicon.Icon use case
Bars stack in industry
Snowball pile
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
circleNaming
icons/[iconName].json.Design
Before Submitting