-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): add search-error icon
#3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jakob Guddas <[email protected]>
jguddas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name should be search-alert
Co-authored-by: Jakob Guddas <[email protected]>
Or possibly |
ericfennis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename it to search-alert to be in line with the other *-alert icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
Added or changed iconsIcons as codeWorks for: const SearchAlertIcon = createLucideIcon('SearchAlert', [
["circle",{"cx":"11","cy":"11","r":"8"}],
["path",{"d":"m21 21-4.3-4.3"}],
["path",{"d":"M11 7v4"}],
["path",{"d":"M11 15h.01"}]
]) |
* feat(icons): add `search-error` icon * Update icons/search-error.svg Co-authored-by: Jakob Guddas <[email protected]> * Update icons/search-error.json Co-authored-by: Jakob Guddas <[email protected]> * chore(icons): rename `search-error` to `search-alert` * Fix indentation contributors in search-alert.json * Format code --------- Co-authored-by: Jakob Guddas <[email protected]> Co-authored-by: Eric Fennis <[email protected]>
feat(icons): add
search-erroriconDescription
Added a new icon named
search-error, representing a magnifying glass with an alert indicator. This icon combines search functionality with a visual warning to indicate an error state or failed search result.Icon use case
Alternative icon designs
Alternative considered: using an “X” mark instead of exclamation point, but the exclamation mark provides clearer association with an error state.
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/search-error.json.Design
Before Submitting