-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(icons): added hd icon
#2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added or changed iconsIcons as codeWorks for: const HdIcon = createLucideIcon('Hd', [
["path",{"d":"M10 12H6"}],
["path",{"d":"M10 15V9"}],
["path",{"d":"M14 14.5a.5.5 0 0 0 .5.5h1a2.5 2.5 0 0 0 2.5-2.5v-1A2.5 2.5 0 0 0 15.5 9h-1a.5.5 0 0 0-.5.5z"}],
["path",{"d":"M6 15V9"}],
["rect",{"x":"2","y":"5","width":"20","height":"14","rx":"2"}]
]) |
|
At that size, the 1px rounding just makes the D look more like an O, in my opinion. And having no rounding would keep consistency with https://lucide.dev/icons/case-upper. |
|
@karsa-mistmere Yup, I think you and I have been toying with the same ideas! @jguddas posted a design for closed captions a couple of weeks ago that I really liked, so I tried applying it to the other icons in the set.
|
|
I don't think HD is all that relevant anymore, tbh. If we cannot make 4K, 5K, 8K etc work, I vote to just skip this. |
Alternatively, if #3483 is voted to go through, we could add similarly themed icons for these, that are very feasible: Edit: same goes for PDF |
|
@karsa-mistmere I do not agree, it is still used in other applications like images and audio. Where the term 4K doesn't exist. |
|
Maybe we should arcify the sharp corners with a .5 radius? |
|
@jguddas Hmm disagree, the current radius matches the monitor shape. |
I mean the D not having any round corners. |
|
@jguddas |
|
I'm happy with adding a .5px radius. I am on travels so expect a couple of days before I amend the PR. |
|
@jamiemlaw Agreed! |
Not bad, but maybe we could enunciate the arcs on the right side a just tiny bit more? |
* Add `hd` icon * Update hd.svg * Update hd.json --------- Co-authored-by: Eric Fennis <[email protected]>




Goes part-way to closing #119
What is the purpose of this pull request?
Description
Adds an
hdiconIcon use case
Alternative icon designs
Open lucide studio
Open lucide studio
Open lucide studio
My main submission follows the same visual format at the currently-proposed closed captions icon. However, if we were in future to add an SD counterpart to this icon, there would not be enough space for the 'S'. For that reason, it might be worth choosing one of the last two alternatives as a way to future-proof things. If that ends up being the case, would the closed caption icon need to be revised, to have the same size of bounding rectangle?
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json.Design
Before Submitting