fix(packages): consistent icon name class #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jguddas
reviewed
Mar 8, 2025
jguddas
reviewed
Mar 8, 2025
jguddas
reviewed
Mar 8, 2025
Contributor
Author
|
Do you know why the Vercel build is failing after I merged main? |
ericfennis
reviewed
Mar 14, 2025
Member
ericfennis
left a comment
ericfennis
left a comment
There was a problem hiding this comment.
Really nice work, thanks for fixing this!
I've found something we need to check. See comment below
ericfennis
changed the title
ericfennis
approved these changes
Mar 21, 2025
Contributor
Author
|
🎉 |
This was referenced Jun 28, 2025
1 task
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2858
What is the purpose of this pull request?
Description
Thanks for taking the time to look at my previous PR!
Based on our previous discussion, I've implemented a different solution. Instead of modifying the
toKebabCasefunction, I've added a new class that's derived from the icon's name on the filesystem.The good news is that this change is fully backwards compatible. The new classes will follow this pattern:
lucide lucide-grid3x3 lucide-grid-3x3This means existing implementations using the current class names will continue to work without any changes needed.
Looking forward to your feedback on this approach.
Before Submitting