Skip to content

feat(icons): added bow-arrow icon #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karsa-mistmere merged 4 commits into from
Apr 18, 2025
Merged

feat(icons): added bow-arrow icon #2418

karsa-mistmere merged 4 commits into from
Apr 18, 2025

Conversation

@jamiemlaw
Copy link
Contributor

@jamiemlaw jamiemlaw commented Aug 29, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Added new bow-arrow icon

Icon use case

  • In a list of Olympic events
  • Showing available activities at an activities centre
  • Denoting a character class in a role playing game whose main proficiency is archery
  • A weapon (or category of weapons) in a video game, e.g. light weapons, medieval weapons

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Aug 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Added or changed icons

icons/bow-arrow.svg

Preview cohesion icons/square-parking-off.svg
icons/bow-arrow.svg
icons/omega.svg
Preview stroke widths icons/bow-arrow.svg
icons/bow-arrow.svg
icons/bow-arrow.svg
DPI Preview (24px) icons/bow-arrow.svg
Icon X-rays icons/bow-arrow.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BowArrowIcon = createLucideIcon('BowArrow', [
  ["path",{"d":"M17 3h4v4"}],
  ["path",{"d":"M18.575 11.082a13 13 0 0 1 1.048 9.027 1.17 1.17 0 0 1-1.914.597L14 17"}],
  ["path",{"d":"M7 10 3.29 6.29a1.17 1.17 0 0 1 .6-1.91 13 13 0 0 1 9.03 1.05"}],
  ["path",{"d":"M7 14a1.7 1.7 0 0 0-1.207.5l-2.646 2.646A.5.5 0 0 0 3.5 18H5a1 1 0 0 1 1 1v1.5a.5.5 0 0 0 .854.354L9.5 18.207A1.7 1.7 0 0 0 10 17v-2a1 1 0 0 0-1-1z"}],
  ["path",{"d":"M9.707 14.293 21 3"}]
])

@jguddas
Copy link
Member

jguddas commented Aug 29, 2024

Pretty clean, I think we should round the corners tho.

@jamiemlaw
Copy link
Contributor Author

jamiemlaw commented Aug 29, 2024

I was on the fence about that when submitting. The arrow tip, of course, should remain pointy. But for the fletching, I've been pixel nudging trying to find the right level of roundedness.

image

I think of the four alternatives (the leftmost image is the original) I'm tempted by the rightmost one.

jguddas
jguddas reviewed Aug 31, 2024
View reviewed changes
icons/bow-arrow.svg Outdated
Comment on lines 12 to 16
<path d="M12.92 5.423A13 13 0 0 0 2 5l5 5" />
<path d="M17 3h4v4" />
<path d="M18.575 11.076a13 13 0 0 1 .428 10.925L14 17" />
<path d="M7 14a1.707 1.707 0 0 0-1.207.5l-2.646 2.646A.5.5 0 0 0 3.5 18H6v2.5a.5.5 0 0 0 .854.354L9.5 18.207A1.707 1.707 0 0 0 10 17v-2a1 1 0 0 0-1-1z" />
<path d="M9.707 14.293 21 3" />
Copy link
Member

@jguddas jguddas Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<path d="M12.92 5.423A13 13 0 0 0 2 5l5 5" />
<path d="M17 3h4v4" />
<path d="M18.575 11.076a13 13 0 0 1 .428 10.925L14 17" />
<path d="M7 14a1.707 1.707 0 0 0-1.207.5l-2.646 2.646A.5.5 0 0 0 3.5 18H6v2.5a.5.5 0 0 0 .854.354L9.5 18.207A1.707 1.707 0 0 0 10 17v-2a1 1 0 0 0-1-1z" />
<path d="M9.707 14.293 21 3" />
<path d="M12.92 5.423a13 13 0 0 0-9.424-.951 1 1 0 0 0-.374 1.65L7 10" />
<path d="M17 3h4v4" />
<path d="M18.575 11.076a13 13 0 0 1 .955 9.428 1 1 0 0 1-1.65.375L14 17" />
<path d="M7 14a1.7 1.7 0 0 0-1.207.5l-2.646 2.646A.5.5 0 0 0 3.5 18H5a1 1 0 0 1 1 1v1.5a.5.5 0 0 0 .854.354L9.5 18.207A1.7 1.7 0 0 0 10 17v-2a1 1 0 0 0-1-1z" />
<path d="M9.707 14.293 21 3" />

icons
Open lucide studio

Copy link
Contributor Author

@jamiemlaw jamiemlaw Sep 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Hadn't thought to round the ends of the bow because I think of them as pointy too. One potential modification, further to yours: if the radius of those curves is increased to $4-2\sqrt{2}$ = 1.17px the arcs line up with the pixel grid.

I'm happy with either. :-)

icons
Open lucide studio

Copy link
Member

@jguddas jguddas Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Hadn't thought to round the ends of the bow because I think of them as pointy too. One potential modification, further to yours: if the radius of those curves is increased to 4 − 2 2 = 1.17px the arcs line up with the pixel grid.

I'm happy with either. :-)

iconsOpen lucide studio

Yeah, that looks nice.

@jamiemlaw
Further arcify bow-arrow.svg
70e4cc1 
Rounded the tips of the bow
@jguddas
Copy link
Member

jguddas commented Sep 3, 2024 •
edited
Loading

Maybe a different bow shape again?

icon (7)

icons
Open lucide studio

@jamiemlaw
Copy link
Contributor Author

jamiemlaw commented Sep 5, 2024

In my opinion, that version as it currently stands is a little too ornate.

I like that the ends are pointed (in fact, I think I prefer the original version of mine with the pointy ends to the arcified version), but I think in the version above they're a bit too curved?

Toning it down a little but still incorporating your more elegant bow shape, we could have:

icons
Open lucide studio

Current contenders:

image

  1. Simple (arcified ends)
  2. Simple (pointy ends)
  3. Elegant (curled ends)
  4. Elegant (pointy ends)

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Sep 11, 2024

I'm voting no. 1, the simple style with arcified ends.

The curvy one is super cute as well, but it is bound to suffer from the increased density.

@jguddas
Copy link
Member

jguddas commented Sep 12, 2024

I'm voting no. 1, the simple style with arcified ends.

The curvy one is super cute as well, but it is bound to suffer from the increased density.

I agree with the density, what about something like this?

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Sep 12, 2024

I'm voting no. 1, the simple style with arcified ends.
The curvy one is super cute as well, but it is bound to suffer from the increased density.

I agree with the density, what about something like this?

iconsOpen lucide studio

Not sure how this is better, the pointy bits (ends of the bow) are still very dense.

@github-actions github-actions bot added the Stale label Oct 13, 2024
@github-actions github-actions bot removed the Stale label Oct 14, 2024
@github-actions github-actions bot added the Stale label Nov 14, 2024
ericfennis
ericfennis approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the current design, clean and simple

@lucide-icons lucide-icons deleted a comment from github-actions bot Apr 18, 2025
@lucide-icons lucide-icons deleted a comment from github-actions bot Apr 18, 2025
@karsa-mistmere karsa-mistmere merged commit 61d6f93 into lucide-icons:main Apr 18, 2025
jpjacobpadilla pushed a commit to briz123/lucide that referenced this pull request Apr 18, 2025
@jamiemlaw @jpjacobpadilla
feat(icons): added bow-arrow icon (lucide-icons#2418)
6cd5a27 
* Added bow-arrow.svg

* Added bow-arrow.json

* Arcify bow-arrow.svg

* Further arcify bow-arrow.svg

Rounded the tips of the bow
@renovate renovate bot mentioned this pull request May 17, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericfennis ericfennis ericfennis approved these changes

@jguddas jguddas jguddas approved these changes

@karsa-mistmere karsa-mistmere Awaiting requested review from karsa-mistmere

Assignees

No one assigned

Labels

🎨 icon About new icons 🫧 metadata Improved metadata Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamiemlaw @jguddas @karsa-mistmere @ericfennis