Skip to content

Commit e042fec

Browse files
unrevised6419claudeericfennis
authored
fix(packages): declare @types/react as an optional peer dependency (#4892)
`lucide-react` and `lucide-react-native` both ship `.d.ts` files that import React types (`ForwardRefExoticComponent`, `SVGProps`, `RefAttributes`, `ReactNode`), but neither package declares `@types/react`. Under a hoisted `node_modules` this resolves by accident, so the gap is invisible in normal testing. It does not resolve under a strict layout — most notably pnpm's global virtual store (`enableGlobalVirtualStore`), where each package is linked from a store path outside the consuming repo. TypeScript resolves a package's imports relative to where that package physically lives and ignores `NODE_PATH`, so `react` resolves to the untyped `react/index.js`. Every icon's props silently degrade to `any`, and consumers hit implicit-any errors on their own callbacks under `noImplicitAny`. `skipLibCheck: true` hides the errors inside the `.d.ts` itself, which is why this survives most typechecks. Declaring the typings package as a peer dependency (rather than a hard dependency) lets it dedupe against whatever `@types/react` the consumer already has. `peerDependenciesMeta` marks it optional so JS-only consumers get no unmet-peer warning. Verified by packing each package and installing the tarball into a scratch consumer with `pnpm --virtual-store-dir` pointing outside the consumer, then typechecking with `skipLibCheck: false` and a `@ts-expect-error` probe on a nonexistent icon prop — a positive type assertion keeps passing when types widen to `any`, so it would not catch a regression. Before the change the probe reports `TS2578: Unused '@ts-expect-error' directive` plus `TS7016` inside the shipped `.d.ts`; after it, `tsc` is clean and `--traceResolution` shows `react` resolving to `@types/react/index.d.ts` instead of `react/index.js`. Existing peer ranges are unchanged and the lockfile is unaffected. Co-authored-by: Claude Opus 5 <[email protected]> Co-authored-by: Eric Fennis <[email protected]>
1 parent c870b3c commit e042fec

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎packages/lucide-react-native/package.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,14 @@
8585
"vite": "^7.3.6"
8686
},
8787
"peerDependencies": {
88+
"@types/react": "*",
8889
"react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0",
8990
"react-native": "*",
9091
"react-native-svg": "^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0"
92+
},
93+
"peerDependenciesMeta": {
94+
"@types/react": {
95+
"optional": true
96+
}
9197
}
9298
}

‎packages/lucide-react/package.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@
6868
"vite": "^7.3.6"
6969
},
7070
"peerDependencies": {
71+
"@types/react": "*",
7172
"react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0"
73+
},
74+
"peerDependenciesMeta": {
75+
"@types/react": {
76+
"optional": true
77+
}
7278
}
7379
}

0 commit comments

Comments
 (0)