Skip to content

Commit dada0a8

Browse files
authored
fix(lucide-react): Fix dynamic imports (#4210)
* fix(lucide-react): Fix dynamic imports * Adjust imports * Format code * Ignore eslint error
1 parent fa09963 commit dada0a8

4 files changed

Lines changed: 29 additions & 4 deletions

File tree

‎.gitignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ packages/**/src/dynamicIconImports.ts
2727
packages/**/DynamicIcon.d.ts
2828
packages/**/dynamicIconImports.js
2929
packages/**/dynamicIconImports.d.ts
30+
packages/**/dynamicIconImports.d.mts
3031
packages/**/dynamicIconImports.js.map
3132
packages/**/dynamic.d.ts
33+
packages/**/dynamic.d.mts
3234
packages/**/dynamic.mjs.map
3335
packages/**/dynamic.mjs
3436
packages/**/LICENSE

‎packages/lucide-react/dynamic.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// This file is make sure that we can import from "lucide-react/dynamic" without having to specify the extension. This is a workaround for the fact that some bundlers (like Webpack) don't support importing from "lucide-react/dynamic.mjs" without specifying the extension.
2+
// Unfortunately, we can't use exports field in package.json because it breaks some runtime environments. See https://github.com/lucide-icons/lucide/issues/2743#issuecomment-2626784300
3+
// eslint-disable-next-line import/no-unresolved
4+
export * from './dynamic.mjs';

‎packages/lucide-react/package.json‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,20 @@
2929
"sideEffects": false,
3030
"files": [
3131
"dist",
32+
"dynamic.js",
3233
"dynamic.mjs",
3334
"dynamic.js.map",
35+
"dynamic.d.mts",
3436
"dynamic.d.ts",
3537
"dynamicIconImports.mjs",
3638
"dynamicIconImports.js.map",
37-
"dynamicIconImports.d.ts"
39+
"dynamicIconImports.d.ts",
40+
"dynamicIconImports.d.mts"
3841
],
3942
"scripts": {
4043
"build": "pnpm clean && pnpm copy:license && pnpm build:icons && pnpm typecheck && pnpm build:bundles",
4144
"copy:license": "cp ../../LICENSE ./LICENSE",
42-
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.ts && rm -f dynamic.* && rm -f dynamicIconImports.d.ts",
45+
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.ts && rm -f dynamic.{d.ts,d.mts,mts,mjs,mjs.map} && rm -f dynamicIconImports.d.ts",
4346
"build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mts --renderUniqueKey --withAliases --withDynamicImports --separateAliasesFile --separateAliasesFileIgnore=fingerprint --aliasesFileExtension=.ts --iconFileExtension=.ts --exportFileName=index.ts",
4447
"build:bundles": "rollup -c ./rollup.config.mjs",
4548
"typecheck": "tsc",

‎packages/lucide-react/rollup.config.mjs‎

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,19 @@ const bundles = [
2121
outputDir: 'dist/esm',
2222
preserveModules: true,
2323
},
24-
2524
{
2625
format: 'esm',
2726
inputs: ['src/dynamicIconImports.ts', 'src/DynamicIcon.ts', ...aliasesEntries],
2827
outputDir: 'dist/esm',
2928
external: [/src/],
3029
preserveModules: true,
30+
paths: (id) => {
31+
if (id.match(/src/)) {
32+
const [, modulePath] = id.match(/src\/(.*)\.ts/);
33+
34+
return `./${modulePath}.js`;
35+
}
36+
},
3137
},
3238
{
3339
format: 'esm',
@@ -63,7 +69,7 @@ const configs = bundles
6369
...plugins({ pkg, minify }),
6470
// Make sure we emit "use client" directive to make it compatible with Next.js
6571
preserveDirectives({
66-
include: ['src/DynamicIcon.ts', 'src/context.ts', 'src/Icon.ts'],
72+
include: ['src/lucide-react.ts', 'src/DynamicIcon.ts', 'src/context.ts', 'src/Icon.ts'],
6773
suppressPreserveModulesWarning: true,
6874
}),
6975
],
@@ -100,6 +106,11 @@ export default [
100106
file: `dynamicIconImports.d.ts`,
101107
format: 'es',
102108
},
109+
// Extra declaration file with .d.mts extension for better compatibility with ESM environments
110+
{
111+
file: `dynamicIconImports.d.mts`,
112+
format: 'es',
113+
},
103114
],
104115
plugins: [dts()],
105116
},
@@ -110,6 +121,11 @@ export default [
110121
file: `dynamic.d.ts`,
111122
format: 'es',
112123
},
124+
// Extra declaration file with .d.mts extension for better compatibility with ESM environments
125+
{
126+
file: `dynamic.d.mts`,
127+
format: 'es',
128+
},
113129
],
114130
plugins: [dts()],
115131
},

0 commit comments

Comments
 (0)