Skip to content

Commit 653e44b

Browse files
feat(packages): use .mjs for ESM bundles (#4285)
1 parent f0eaba8 commit 653e44b

16 files changed

Lines changed: 53 additions & 36 deletions

File tree

‎.gitignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ packages/**/src/utils/*.ts
2626
packages/**/src/dynamicIconImports.ts
2727
packages/**/DynamicIcon.d.ts
2828
packages/**/dynamicIconImports.js
29+
packages/**/dynamicIconImports.mjs
2930
packages/**/dynamicIconImports.d.ts
3031
packages/**/dynamicIconImports.d.mts
3132
packages/**/dynamicIconImports.js.map
33+
packages/**/dynamicIconImports.mjs.map
3234
packages/**/dynamic.d.ts
3335
packages/**/dynamic.d.mts
3436
packages/**/dynamic.mjs.map

‎packages/lucide-preact/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
"author": "Eric Fennis",
2525
"amdName": "lucide-preact",
2626
"main": "dist/cjs/lucide-preact.js",
27-
"module": "dist/esm/lucide-preact.js",
27+
"module": "dist/esm/lucide-preact.mjs",
2828
"exports": {
2929
".": {
3030
"types": "./dist/lucide-preact.d.ts",
31-
"import": "./dist/esm/lucide-preact.js",
31+
"import": "./dist/esm/lucide-preact.mjs",
3232
"require": "./dist/cjs/lucide-preact.js"
3333
}
3434
},

‎packages/lucide-preact/rollup.config.mjs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@ const bundles = [
1717
inputs,
1818
outputDir,
1919
preserveModules: true,
20+
extension: 'mjs',
2021
},
2122
];
2223

2324
const configs = bundles
24-
.map(({ inputs, outputDir, format, preserveModules }) =>
25+
.map(({ inputs, outputDir, format, preserveModules, extension = 'js' }) =>
2526
inputs.map((input) => ({
2627
input,
2728
plugins: plugins({ pkg }),
@@ -31,9 +32,10 @@ const configs = bundles
3132
...(preserveModules
3233
? {
3334
dir: `${outputDir}/${format}`,
35+
entryFileNames: `[name].${extension}`,
3436
}
3537
: {
36-
file: `${outputDir}/${format}/${outputFileName}.js`,
38+
file: `${outputDir}/${format}/${outputFileName}.${extension}`,
3739
}),
3840
preserveModules,
3941
format,

‎packages/lucide-react-native/package.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,20 @@
2424
"author": "Eric Fennis",
2525
"amdName": "lucide-react-native",
2626
"main": "dist/cjs/lucide-react-native.js",
27-
"module": "dist/esm/lucide-react-native.js",
27+
"module": "dist/esm/lucide-react-native.mjs",
2828
"typings": "dist/lucide-react-native.d.ts",
29-
"react-native": "dist/esm/lucide-react-native.js",
29+
"react-native": "dist/esm/lucide-react-native.mjs",
3030
"exports": {
3131
".": {
3232
"types": "./dist/lucide-react-native.d.ts",
33-
"import": "./dist/esm/lucide-react-native.js",
34-
"browser": "./dist/esm/lucide-react-native.js",
33+
"import": "./dist/esm/lucide-react-native.mjs",
34+
"browser": "./dist/esm/lucide-react-native.mjs",
3535
"require": "./dist/cjs/lucide-react-native.js"
3636
},
3737
"./icons": {
3838
"types": "./dist/icons.d.ts",
39-
"import": "./dist/esm/icons/index.js",
40-
"browser": "./dist/esm/icons/index.js",
39+
"import": "./dist/esm/icons/index.mjs",
40+
"browser": "./dist/esm/icons/index.mjs",
4141
"require": "./dist/cjs/icons/index.js"
4242
}
4343
},

‎packages/lucide-react-native/rollup.config.mjs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ const bundles = [
1818
inputs,
1919
outputDir,
2020
preserveModules: true,
21+
extension: 'mjs',
2122
},
2223
];
2324

2425
const configs = bundles
25-
.map(({ inputs, outputDir, format, preserveModules }) =>
26+
.map(({ inputs, outputDir, format, preserveModules, extension = 'js' }) =>
2627
inputs.map((input) => ({
2728
input,
2829
plugins: plugins({ pkg }),
@@ -33,9 +34,10 @@ const configs = bundles
3334
? {
3435
dir: `${outputDir}/${format}`,
3536
exports: 'auto',
37+
entryFileNames: `[name].${extension}`,
3638
}
3739
: {
38-
file: `${outputDir}/${format}/${outputFileName}.js`,
40+
file: `${outputDir}/${format}/${outputFileName}.${extension}`,
3941
}),
4042
format,
4143
preserveModules,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { default } from './dist/esm/dynamicIconImports.js';
1+
export { default } from './dist/esm/dynamicIconImports.mjs';

‎packages/lucide-react/package.json‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,17 @@
2424
"author": "Eric Fennis",
2525
"amdName": "lucide-react",
2626
"main": "dist/cjs/lucide-react.js",
27-
"module": "dist/esm/lucide-react.js",
27+
"module": "dist/esm/lucide-react.mjs",
2828
"typings": "dist/lucide-react.d.ts",
2929
"sideEffects": false,
3030
"files": [
3131
"dist",
3232
"dynamic.js",
3333
"dynamic.mjs",
34-
"dynamic.js.map",
34+
"dynamic.mjs.map",
3535
"dynamic.d.mts",
3636
"dynamic.d.ts",
3737
"dynamicIconImports.mjs",
38-
"dynamicIconImports.js.map",
3938
"dynamicIconImports.d.ts",
4039
"dynamicIconImports.d.mts"
4140
],

‎packages/lucide-react/rollup.config.mjs‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,27 @@ const bundles = [
1414
format: 'cjs',
1515
inputs,
1616
outputDir: 'dist/cjs',
17+
extension: 'js',
1718
},
1819
{
1920
format: 'esm',
2021
inputs,
2122
outputDir: 'dist/esm',
2223
preserveModules: true,
24+
extension: 'mjs',
2325
},
2426
{
2527
format: 'esm',
2628
inputs: ['src/dynamicIconImports.ts', 'src/DynamicIcon.ts', ...aliasesEntries],
2729
outputDir: 'dist/esm',
2830
external: [/src/],
2931
preserveModules: true,
32+
extension: 'mjs',
3033
paths: (id) => {
3134
if (id.match(/src/)) {
3235
const [, modulePath] = id.match(/src\/(.*)\.ts/);
3336

34-
return `./${modulePath}.js`;
37+
return `./${modulePath}.mjs`;
3538
}
3639
},
3740
},
@@ -40,11 +43,12 @@ const bundles = [
4043
inputs: ['src/dynamic.ts'],
4144
outputFile: 'dynamic.mjs',
4245
external: [/src/],
46+
extension: 'mjs',
4347
paths: (id) => {
4448
if (id.match(/src/)) {
4549
const [, modulePath] = id.match(/src\/(.*)\.ts/);
4650

47-
return `dist/esm/${modulePath}.js`;
51+
return `dist/esm/${modulePath}.mjs`;
4852
}
4953
},
5054
},
@@ -60,6 +64,7 @@ const configs = bundles
6064
minify,
6165
preserveModules,
6266
entryFileNames,
67+
extension = 'js',
6368
external = [],
6469
paths,
6570
}) =>
@@ -79,12 +84,12 @@ const configs = bundles
7984
...(preserveModules
8085
? {
8186
dir: outputDir,
87+
entryFileNames: entryFileNames ?? `[name].${extension}`,
8288
}
8389
: {
84-
file: outputFile ?? `${outputDir}/${outputFileName}.js`,
90+
file: outputFile ?? `${outputDir}/${outputFileName}.${extension}`,
8591
}),
8692
paths,
87-
entryFileNames,
8893
format,
8994
sourcemap: true,
9095
preserveModules,

‎packages/lucide-solid/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"author": "Eric Fennis",
2626
"source": "src/lucide-solid.ts",
2727
"main": "dist/cjs/lucide-solid.js",
28-
"module": "dist/esm/lucide-solid.js",
28+
"module": "dist/esm/lucide-solid.mjs",
2929
"types": "dist/types/lucide-solid.d.ts",
3030
"files": [
3131
"dist"
@@ -34,22 +34,22 @@
3434
".": {
3535
"types": "./dist/types/lucide-solid.d.ts",
3636
"solid": "./dist/source/lucide-solid.jsx",
37-
"import": "./dist/esm/lucide-solid.js",
38-
"browser": "./dist/esm/lucide-solid.js",
37+
"import": "./dist/esm/lucide-solid.mjs",
38+
"browser": "./dist/esm/lucide-solid.mjs",
3939
"require": "./dist/cjs/lucide-solid.js"
4040
},
4141
"./icons": {
4242
"types": "./dist/types/lucide-solid.d.ts",
4343
"solid": "./dist/source/lucide-solid.jsx",
44-
"import": "./dist/esm/lucide-solid.js",
45-
"browser": "./dist/esm/lucide-solid.js",
44+
"import": "./dist/esm/lucide-solid.mjs",
45+
"browser": "./dist/esm/lucide-solid.mjs",
4646
"require": "./dist/cjs/lucide-solid.js"
4747
},
4848
"./icons/*": {
4949
"types": "./dist/types/icons/*.d.ts",
5050
"solid": "./dist/source/icons/*.jsx",
51-
"import": "./dist/esm/icons/*.js",
52-
"browser": "./dist/esm/icons/*.js",
51+
"import": "./dist/esm/icons/*.mjs",
52+
"browser": "./dist/esm/icons/*.mjs",
5353
"require": "./dist/cjs/icons/*.js"
5454
}
5555
},

‎packages/lucide-solid/rollup.config.mjs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ const bundles = [
2323
inputs,
2424
outputDir,
2525
preserveModules: true,
26+
extension: 'mjs',
2627
},
2728
];
2829

2930
const configs = bundles
30-
.map(({ inputs, outputDir, format, preserveModules }) =>
31+
.map(({ inputs, outputDir, format, preserveModules, extension = 'js' }) =>
3132
inputs.map((input) => ({
3233
input,
3334
plugins: [
@@ -117,9 +118,10 @@ const configs = bundles
117118
? {
118119
dir: `${outputDir}/${format}`,
119120
exports: 'auto',
121+
entryFileNames: `[name].${extension}`,
120122
}
121123
: {
122-
file: `${outputDir}/${format}/${outputFileName}.js`,
124+
file: `${outputDir}/${format}/${outputFileName}.${extension}`,
123125
}),
124126
format: format === 'source' ? 'esm' : format,
125127
preserveModules,

0 commit comments

Comments
 (0)