Skip to content

Commit 02eb916

Browse files
ronitgupta138ericfennisCopilot
authored
feat(svelte): export __iconData and __iconNode across per-icon modules (#4936) (#4957)
* feat(svelte): export __iconData and __iconNode across per-icon modules (#4936) * Refactor imports in lucide-svelte.spec.ts Co-authored-by: Copilot Autofix powered by AI <[email protected]> * fix(build-icons): scope per-icon data re-exports behind exportIconData flag - Problem: generateAliasesFiles unconditionally re-exported __iconData and __iconNode for all packages using separateAliasesFile. Packages like @lucide/solid and @lucide/icons do not export these names from their templates, causing missing export errors in downstream bundlers (e.g. solid vite integration). - Solution: Add exportIconData flag (default false) to CLI, generateIconFiles, and generateAliasesFiles so named re-exports are opt-in and only emitted for packages that define them (@lucide/svelte). * refactor(svelte): remove tools/build-icons changes per maintainer review --------- Co-authored-by: Eric Fennis <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]>
1 parent 0ab9c70 commit 02eb916

2 files changed

Lines changed: 25 additions & 4 deletions

File tree

‎packages/svelte/scripts/exportTemplate.mts‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,23 @@ export default defineExportTemplate(
99

1010
return `\
1111
${getHTMLBanner()}
12+
<script module lang="ts">
13+
import type { LucideIconData, LucideIconNode } from '../types.js';
14+
15+
export const __iconData: LucideIconData = ${JSON.stringify(iconData)};
16+
17+
/**
18+
* @deprecated Access \`__iconData\` instead.
19+
*/
20+
export const __iconNode: LucideIconNode[] = __iconData.node;
21+
</script>
22+
1223
<script lang="ts">
1324
import Icon from '../Icon.svelte';
14-
import type { LucideProps, LucideIconData } from '../types.js';
25+
import type { LucideProps } from '../types.js';
1526
1627
let props: LucideProps = $props();
1728
18-
const iconData: LucideIconData = ${JSON.stringify(iconData)};
19-
2029
</script>
2130
2231
<!--
@@ -29,7 +38,7 @@ Lucide SVG icon component, renders SVG Element with children.
2938
${deprecated ? `\n@deprecated ${deprecationReason}\n` : ''}\
3039
-->
3140
32-
<Icon {...props} icon={iconData} />
41+
<Icon {...props} icon={__iconData} />
3342
`;
3443
},
3544
);

‎packages/svelte/tests/lucide-svelte.spec.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { describe, it, expect, afterEach } from 'vitest';
22
import { render, cleanup } from '@testing-library/svelte';
33
import { Smile, Pen, Edit2 } from '../src/lucide-svelte.js';
4+
import { __iconData, __iconNode } from '../src/icons/face-slightly-smiling.svelte';
45
import TestSlots from './TestSlots.svelte';
56
import ContextWrapper from './ContextWrapper.svelte';
67

@@ -132,3 +133,14 @@ describe('Icon Component Accessibility', () => {
132133
expect(container.firstChild).not.toHaveAttribute('aria-hidden');
133134
});
134135
});
136+
137+
describe('Per-icon data export', () => {
138+
it('should export __iconData and __iconNode from the svelte component module', () => {
139+
expect(__iconData).toBeDefined();
140+
expect(__iconData.name).toBe('face-slightly-smiling');
141+
expect(__iconData.size).toBe(24);
142+
expect(Array.isArray(__iconData.node)).toBe(true);
143+
expect(__iconData.node.length).toBeGreaterThan(0);
144+
expect(__iconNode).toEqual(__iconData.node);
145+
});
146+
});

0 commit comments

Comments
 (0)