Skip to content

Add missing deps #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucacome merged 1 commit into from
Nov 25, 2025
Merged

Add missing deps #717

lucacome merged 1 commit into from
Nov 25, 2025

Conversation

@lucacome
Copy link
Owner

@lucacome lucacome commented Nov 11, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated development dependencies for build tooling optimization.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025 •
edited
Loading

Walkthrough

Updated dev dependencies in package.json by removing eslint-import-resolver-typescript and ts-node, and adding @eslint/eslintrc and globals. This appears to align with an ESLint configuration modernization effort.

Changes

Cohort / File(s) Summary
Dev Dependency Updates
package.json		 Added @eslint/eslintrc and globals to devDependencies; removed eslint-import-resolver-typescript and ts-node from devDependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that ESLint configuration files have been updated to use the new dependencies (@eslint/eslintrc, globals) if they weren't included in this diff
  • Confirm that removing ts-node doesn't break any build scripts or tooling that depend on it
  • Confirm that removing eslint-import-resolver-typescript is intentional and not required elsewhere

Possibly related PRs

  • Update dependencies #701: Modifies the same dependency (eslint-import-resolver-typescript) in package.json, making it a related configuration change.

Poem

🐰 A dusty toolbox cleaned with care,
Old resolvers bid farewell, no despair,
Globals and eslintrc, fresh and bright,
The rabbit hops forth—ESLint takes flight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Add missing deps' is vague and doesn't explain which specific dependencies were added or removed, or the purpose of the changes. Consider a more descriptive title that specifies the key changes, such as 'Add @eslint/eslintrc and globals, remove unused deps' or provide context about why these dependencies were added or removed.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/deps
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5419069 and c16e000.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (2 hunks)
🔇 Additional comments (1)
package.json (1)

14-14: Dependency changes verified and safe.

Both added versions are current and properly configured for ESLint 9.x:

The removed packages (eslint-import-resolver-typescript and ts-node) are completely absent from the codebase and not referenced in eslint.config.mjs. The changes are safe to merge.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore labels Nov 11, 2025
coderabbitai[bot]
coderabbitai bot requested changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
package.json (1)

13-39: Critical: eslint-import-resolver-typescript removal is incomplete — ESLint config still references it.

The eslint.config.mjs contains 'import/resolver': { typescript: { ... } } configuration, but the package was removed. This will cause ESLint to fail at runtime with a missing resolver error. Either:

  • Reinstate eslint-import-resolver-typescript in devDependencies, or
  • Update eslint.config.mjs to remove the typescript resolver setting and use the built-in node resolver instead

ts-node removal is safe — no references found in the codebase.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bb05c7 and 60365a2.

⛔ Files ignored due to path filters (3)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • src/release.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/release.ts (1)
dist/index.js (7)
  • releases (45854-45857)
  • releases (45889-45889)
  • client (48039-48039)
  • context (45254-45254)
  • context (45851-45851)
  • context (45888-45888)
  • context (48027-48027)
🔇 Additional comments (1)
package.json (1)

15-15: LGTM! Modern ESLint configuration dependencies added.

The additions of @eslint/eslintrc and globals align with modern ESLint configuration practices, replacing the older TypeScript-specific resolver.

Also applies to: 31-31

@lucacome lucacome merged commit 0ebb400 into main Nov 25, 2025
15 checks passed
@lucacome lucacome deleted the chore/deps branch November 25, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

chore dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucacome