Fix: Escape special characters in tab titles to prevent block crash #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29
This PR fixes a bug where the tabs block crashes when a tab title contains special characters (e.g., apostrophe
', quotes", etc.).Problem
The
data-wp-contextattribute insrc/tabs/render. phpwas not properly escaping the JSON output:When a tab title like
L'ongletwas used, the generated HTML would break:data-wp-context='{"tabs":[{"label":"L'onglet"... }]}'The apostrophe in the title prematurely closes the HTML attribute, causing the block to crash.
Solution
Wrap
wp_json_encode()withesc_attr()to properly escape special characters:This ensures that special characters are encoded as HTML entities (
'→') in the attribute, while the browser automatically decodes them when parsing, so the title displays correctly on screen.Testing
It's working!orTest "quotes")