Skip to content

Update #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lubitchv merged 75 commits into from
Jun 6, 2022
Merged

Update #64

lubitchv merged 75 commits into from
Jun 6, 2022

Conversation

@lubitchv
Copy link
Owner

@lubitchv lubitchv commented Jun 6, 2022

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

ErykKul and others added 30 commits March 24, 2022 16:09
@ErykKul
New feature for muting email and/or in-app notifications by users for…
4878379 
… given types of notifications
@ErykKul
added tests to AuthenticatedUserTest.java
99b47e0
@ErykKul
muting properties are now better documented and moved to more logical…
2341435 
… position in bundle.properties
@ErykKul
added support for muting notification types for the installation wher…
9b79afb 
…e users cannot unmuted these muted types
@ErykKul
implementation of in review requested changes
abe1af2
@ErykKul
bugfix: user notification bean did not use settings wrapper
2aabda1
@ErykKul
nullpointer fix
18f7b5b
@ErykKul
fixed the remaining bugs after refactoring
437df33
@ErykKul
added requested changes
ef12352
@ErykKul
alternative UI for muting notifications
b2f684a
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-make_BagGen…
460fd87 
…erator_threads_configurable
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-improve_Bag…
7c7ebe0 
…Gnerator_failure_handling
@qqmyers
remove thread config code
a9f3aa5
@ErykKul
removed unused import
3bc644f
@ErykKul
resolved merge conflict
70e01d9
@ErykKul
renames of the notification variables in AuthenticatedUser
4fd7e53
@ErykKul
resolved merge conflict
8d2e3ce
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
8f2afd7
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
782c5a2
@ErykKul
muting options are now collapsible and the logic is inverterd: you se…
cf13a0b 
…lect notifications that you want to receive, not to muted
@ErykKul
bugfix in inverted muting logic
e5e80d8
@ErykKul
when saving notification settings the settings panel collapses
1607359
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
32cb770
@ErykKul
when saving notification settings the settings panel collapses; added…
f2b26fe 
… update property
@ErykKul
fixed inconsistencies when switching tabs and improved accessibility
a83cfff
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
9c2d8ec
@ErykKul
always muted notifications are no longer shown in notification muttin…
efb9951 
…g settings
@ErykKul
bumped flyway script filename according to the current release
6b4bd0f
@ErykKul
bumped flyway script filename according to the current release
fde4989
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
2a9d840
pdurbin and others added 25 commits May 18, 2022 17:01
@pdurbin
add more API tests for notifications #7492
04ecb67
@pdurbin
Merge branch 'develop' into 7492_muting_notifications #7492
d861089
@pdurbin
mention notification API updates in release note #7492 #8487
76c49c2
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
3feb296
@qqmyers
change exception
9469fad 
duplicate_table is thrown when the constraint is unique
@pdurbin
mention API in User Guide section on notifications #7492
986518f
@pdurbin
fix copy/paste issue (in-app vs email) #7492
ca87b28
@qqmyers
update logic now that mdLang can be null
73db830
@ErykKul
better error handling when the notification type does not exist
aa38724
@sekmiller
#8646 carry TOA over to access popup on template change
307a6f2
@sekmiller
Merge branch 'develop' into 8646-TOA-on-restrict-file-popup
b541dc9
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into IQSS/8698-fix_bag-in…
9dae275 
…fo.txt_file_creation
@abujeda
BagIt Support - Add automatic checksum validation on upload
a88da4e
@kcondon
Merge pull request #8530 from ErykKul/7492_muting_notifications
7ce1802 
New feature for muting email and/or in-app notifications
@sekmiller
#8646 fix toa refresh on change template
826acba
@sekmiller
Merge branch 'develop' into 8646-TOA-on-restrict-file-popup
d246f1d
@kcondon
Merge pull request #8677 from adaybujeda/8608-bagit-upload-support-ch…
1df6b63 
…ecksums

BagIt Support - Add automatic checksum validation on upload
@sekmiller
Merge branch 'develop' into 8646-TOA-on-restrict-file-popup
3ea5b20
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into
c89a9a1 
TDL/7493-improve_BagGnerator_failure_handling
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into IQSS/8698-fix_bag-in…
d531d9c 
…fo.txt_file_creation
@qqmyers
Merge branch 'develop' of https://github.com/IQSS/dataverse.git into …
f1c0600 
…IQSS/8728-incorrect_text_with_no_metadatalanguage_setting
@kcondon
Merge pull request #8734 from IQSS/8646-TOA-on-restrict-file-popup
552dfc8 
#8646 carry TOA over to access popup on template change
@kcondon
Merge pull request #8699 from GlobalDataverseCommunityConsortium/IQSS…
4d10da5 
…/8698-fix_bag-info.txt_file_creation

IQSS/8698 - fix bag-info.txt file creation
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into TDL/7493-improve_Bag…
465bb8c 
…Gnerator_failure_handling
@kcondon
Merge pull request #8609 from TexasDigitalLibrary/TDL/7493-improve_Ba…
4947992 
…gGnerator_failure_handling

TDL/7493 Improve BagGenerator failure handling
@lubitchv lubitchv merged commit f2946cb into lubitchv:develop Jun 6, 2022
@coveralls
Copy link

coveralls commented Jun 6, 2022

Pull Request Test Coverage Report for Build #38

  • 440 of 697 (63.13%) changed or added relevant lines in 31 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.5%) to 19.711%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/util/bagit/BagValidation.java 33 34 97.06%
src/main/java/edu/harvard/iq/dataverse/util/bagit/OREMap.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/util/bagit/data/DataFileDataProvider.java 30 31 96.77%
src/main/java/edu/harvard/iq/dataverse/util/bagit/data/FolderDataProvider.java 20 21 95.24%
src/main/java/edu/harvard/iq/dataverse/api/datadeposit/MediaResourceManagerImpl.java 0 2 0.0%
src/main/java/edu/harvard/iq/dataverse/datasetutility/AddReplaceFileHelper.java 0 2 0.0%
src/main/java/edu/harvard/iq/dataverse/util/file/BagItFileHandler.java 70 72 97.22%
src/main/java/edu/harvard/iq/dataverse/util/file/BagItFileHandlerFactory.java 18 21 85.71%
src/main/java/edu/harvard/iq/dataverse/UserServiceBean.java 0 4 0.0%
src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java 1 0%
src/main/java/edu/harvard/iq/dataverse/util/FileUtil.java 1 26.6%
src/main/java/edu/harvard/iq/dataverse/DatasetPage.java 2 0%
src/main/java/edu/harvard/iq/dataverse/export/ddi/DdiExportUtil.java 6 73.08%
Totals Coverage Status
Change from base Build #35: 0.5%
Covered Lines: 15056
Relevant Lines: 76384
💛 - Coveralls

lubitchv pushed a commit that referenced this pull request Aug 4, 2022
#64 bump Tika to 2.4.0
e307ee5
lubitchv pushed a commit that referenced this pull request Aug 4, 2022
#64 Tika 2.4.0 fixes were incomplete, bump to 2.4.1
6b9c54a
lubitchv pushed a commit that referenced this pull request Aug 4, 2022
@kcondon
Merge pull request IQSS#8779 from OdumInstitute/64_tika_2_4_0
7c1039f 
#64 bump Tika to 2.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lubitchv @coveralls @ErykKul @qqmyers @pdurbin @sekmiller @abujeda @kcondon