Bug: 'string.concat' error message uses wrong format

roberto-ieru · roberto-ieru · commit c03c527fd207 · 2021-02-15T13:31:45.000-03:00
diff --git a/ltablib.c b/ltablib.c
@@ -146,7 +146,7 @@ static int tmove (lua_State *L) {
 static void addfield (lua_State *L, luaL_Buffer *b, lua_Integer i) {
   lua_geti(L, 1, i);
   if (!lua_isstring(L, -1))
-    luaL_error(L, "invalid value (%s) at index %d in table for 'concat'",
+    luaL_error(L, "invalid value (%s) at index %I in table for 'concat'",
                   luaL_typename(L, -1), i);
   luaL_addvalue(b);
 }
diff --git a/testes/strings.lua b/testes/strings.lua
@@ -361,6 +361,9 @@ assert(load("return 1\n--comment without ending EOL")() == 1)
 
 
 checkerror("table expected", table.concat, 3)
+checkerror("at index " .. maxi, table.concat, {}, " ", maxi, maxi)
+-- '%' escapes following minus signal
+checkerror("at index %" .. mini, table.concat, {}, " ", mini, mini)
 assert(table.concat{} == "")
 assert(table.concat({}, 'x') == "")
 assert(table.concat({'\0', '\0\1', '\0\1\2'}, '.\0.') == "\0.\0.\0\1.\0.\0\1\2")

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ static int tmove (lua_State *L) {`
`146`	`146`	`static void addfield (lua_State L, luaL_Buffer b, lua_Integer i) {`
`147`	`147`	`lua_geti(L, 1, i);`
`148`	`148`	`if (!lua_isstring(L, -1))`
`149`		`- luaL_error(L, "invalid value (%s) at index %d in table for 'concat'",`
	`149`	`+ luaL_error(L, "invalid value (%s) at index %I in table for 'concat'",`
`150`	`150`	`luaL_typename(L, -1), i);`
`151`	`151`	`luaL_addvalue(b);`
`152`	`152`	`}`