Bug: 'local function' can assign to '<const>' variables

roberto-ieru · roberto-ieru · commit 6a0dace25a4b · 2021-06-20T15:36:36.000-03:00
diff --git a/lparser.c b/lparser.c
@@ -1785,6 +1785,7 @@ static void funcstat (LexState *ls, int line) {
   luaX_next(ls);  /* skip FUNCTION */
   ismethod = funcname(ls, &v);
   body(ls, &b, ismethod, line);
+  check_readonly(ls, &v);
   luaK_storevar(ls->fs, &v, &b);
   luaK_fixline(ls->fs, line);  /* definition "happens" in the first line */
 }
diff --git a/testes/locals.lua b/testes/locals.lua
@@ -187,6 +187,8 @@ do   -- constants
   checkro("y", "local x, y <const>, z = 10, 20, 30; x = 11; y = 12")
   checkro("x", "local x <const>, y, z <const> = 10, 20, 30; x = 11")
   checkro("z", "local x <const>, y, z <const> = 10, 20, 30; y = 10; z = 11")
+  checkro("foo", "local foo <const> = 10; function foo() end")
+  checkro("foo", "local foo <const> = {}; function foo() end")
 
   checkro("z", [[
     local a, z <const>, b = 10;

Original file line number	Diff line number	Diff line change
`@@ -1785,6 +1785,7 @@ static void funcstat (LexState *ls, int line) {`
`1785`	`1785`	`luaX_next(ls); /* skip FUNCTION */`
`1786`	`1786`	`ismethod = funcname(ls, &v);`
`1787`	`1787`	`body(ls, &b, ismethod, line);`
	`1788`	`+ check_readonly(ls, &v);`
`1788`	`1789`	`luaK_storevar(ls->fs, &v, &b);`
`1789`	`1790`	`luaK_fixline(ls->fs, line); /* definition "happens" in the first line */`
`1790`	`1791`	`}`