Repository navigation
DM-24404: Squash warnings from astropy's failure to close ecsv files. - #192
Merged
Merged
Conversation
timj
approved these changes
Apr 9, 2020
timj
left a comment
timj
left a comment
Member
There was a problem hiding this comment.
I'm fine with this. I need to ping the astropy ticket again.
| # Squash warnings due to astropy failure to close files; we think | ||
| # this is a real problem, but the warnings are even worse. | ||
| # https://github.com/astropy/astropy/issues/8673 | ||
| warnings.simplefilter("ignore") |
Member
There was a problem hiding this comment.
Is it possible to catch the specific warning but let others through?
There was a problem hiding this comment.
Yes, it is possible. If you want, you can catch it in many different levels. I think catching ResourceWarning from astropy.io.ascii should be specific enough that you don't have to worry about other warnings being masked? We apologize for any inconvenience caused.
Member
Author
There was a problem hiding this comment.
Thanks for the tip; I've switched to only catching ResourceWarning from astropy.io.ascii and can confirm that it works.
TallJimbo
force-pushed
the
tickets/DM-24404
branch
from
April 9, 2020 20:08
26256d2 to
cef87e6
Compare
TallJimbo
force-pushed
the
tickets/DM-24404
branch
from
April 10, 2020 00:32
cef87e6 to
8a41728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.