Support multipolygon building holes and fix indoor highway bridges#756
Merged
Support multipolygon building holes and fix indoor highway bridges#756
Conversation
|
⏱️ Benchmark run finished in 0m 34s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-02-14 21:02:51 UTC You can retrigger the benchmark by commenting |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the OSM-to-world generation pipeline to better handle building relations with inner rings (courtyards/holes) and to avoid incorrect bridge/support generation for indoor highways.
Changes:
- Expand building-relation detection and member-role handling in
osm_parserfor building-tagged multipolygons. - Add inner-ring (“hole”) support for building relations and render courtyard walls in the building generator.
- Adjust highway layer handling to treat indoor ways as ground-level.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/osm_parser.rs |
Treat building-tagged multipolygon relations as building relations and adjust default member-role handling. |
src/element_processing/highways.rs |
Clamp negative layer and force layer_value=0 for indoor=yes ways. |
src/element_processing/buildings.rs |
Introduce hole polygons, subtract hole areas from the filled footprint, and render walls for inner rings in building relations. |
src/data_processing.rs |
Update generate_buildings call-site for the new hole_polygons argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.