Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes “boundary” element/relation handling from the Overpass fetch and OSM parsing pipeline, aligning the codebase with the goal of dropping boundary relation support.
Changes:
- Removed
boundaryfrom the Overpass tag query. - Stopped parsing
type=boundaryrelations and removed boundary-specific unclipped-way handling. - Updated UI/CLI text to reflect “city ground” behavior and clarified a Java-specific tooltip.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/retrieve_data.rs |
Stops requesting nwr["boundary"] from Overpass. |
src/osm_parser.rs |
Drops type=boundary relation processing and removes boundary-related unclipped-way logic. |
src/floodfill_cache.rs |
Removes boundary-tagged ways from flood-fill eligibility. |
src/args.rs |
Updates CLI help text to “city ground generation”. |
src/gui/index.html |
Clarifies the save-path tooltip to specify Minecraft Java worlds. |
Comments suppressed due to low confidence (1)
src/args.rs:63
- The help text now describes “city ground generation”, but the flag/field name is still
city_boundaries(CLI option will be--city-boundaries). That mismatch is confusing for CLI users; consider renaming the flag to something like--city-ground(and keeping--city-boundariesas an alias for backward compatibility), or explicitly note in the doc comment that--city-boundariesis a legacy name.
/// Enable city ground generation (optional)
/// When enabled, detects building clusters and places stone ground in urban areas.
/// Isolated buildings in rural areas will keep grass around them.
#[arg(long, default_value_t = true)]
pub city_boundaries: bool,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⏱️ Benchmark run finished in 0m 26s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-02-14 16:05:33 UTC You can retrigger the benchmark by commenting |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.