Conversation
|
⏱️ Benchmark run finished in 0m 38s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-02-08 22:02:06 UTC You can retrigger the benchmark by commenting |
There was a problem hiding this comment.
Pull request overview
This PR updates both CLI and GUI world-generation flows to better support Bedrock output, introduces a configurable Java save path in the GUI, and hardens terrain/object processing to avoid pathological memory usage.
Changes:
- Add CLI support for Bedrock
.mcworldoutput with derived output path/level name and argument validation updates. - Replace GUI “choose/select world” flow with “create world” and add a persistent “save path” setting (plus new Tauri commands).
- Add flood-fill safety cap and stop combining relation outer ways into mega-polygons to prevent multi-GB allocations.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Adds Bedrock CLI output path/name handling and uses generate_world_with_options. |
| src/args.rs | Makes --path optional (Bedrock) and adds post-parse argument validation + tests. |
| src/data_processing.rs | Removes legacy CLI wrapper and guards Java-only spawn-Y update behind args.path. |
| src/gui.rs | Replaces world selection command with world creation + save-path commands; updates Args construction for GUI generation. |
| src/gui/js/main.js | Updates UI flow to “Create World”, adds save-path initialization/validation, and adjusts localization mapping. |
| src/gui/index.html | Removes world picker modal and adds save-path UI in settings. |
| src/gui/css/styles.css | Styles the new save-path input + browse button. |
| src/gui/locales/en-US.json | Updates strings/keys for “create world” flow and adds save-path/Bedrock strings. |
| src/gui/locales/zh-CN.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/ua.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/sv.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/ru.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/pl.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/lv.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/lt.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/ko.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/hu.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/fr-FR.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/fi.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/es.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/de.json | Same localization key updates and new save-path/Bedrock strings. |
| src/gui/locales/ar.json | Same localization key updates and new save-path/Bedrock strings. |
| src/floodfill.rs | Adds a bounding-box area cap to prevent OOM from huge fills. |
| src/element_processing/natural.rs | Avoids combining relation outer ways; processes outers individually with relation tags. |
| src/element_processing/leisure.rs | Avoids combining relation outer ways; processes outers individually with relation tags. |
| src/element_processing/landuse.rs | Avoids combining relation outer ways; processes outers individually with relation tags. |
| Cargo.toml | Makes dirs non-optional and adjusts GUI feature deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.