Merged
Conversation
|
⏱️ Benchmark run finished in 0m 24s 📈 Compared against baseline: 30s ✅ This PR improves generation time. 📅 Last benchmark: 2026-01-31 17:22:55 UTC You can retrigger the benchmark by commenting |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the world saving performance by caching base chunk sections and removing unnecessary merge logic when creating fresh worlds.
Changes:
- Introduces
OnceLockfor caching base chunk sections (grass at Y=-62) to avoid recomputing them for every empty chunk - Simplifies
save_single_region()by removing logic that reads and merges existing chunk data, since the code always creates fresh region files with.truncate(true) - Adds
Clonetrait toSection,Blockstates, andPaletteItemstructs to support efficient section caching
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/world_editor/java.rs | Adds OnceLock caching for base chunk sections, simplifies save_single_region by removing merge logic, and marks unused helper functions as dead_code |
| src/world_editor/common.rs | Adds Clone trait to Section, Blockstates, and PaletteItem for efficient cloning of cached sections |
| src/data_processing.rs | Adds new block type imports (GRASS, SMOOTH_STONE, STONE_BRICK_SLAB) though they appear unused |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.