Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Nix flake configuration to build the arnis package directly rather than only providing a development shell. It removes the flake-utils dependency and adds documentation for running the application via Nix.
Changes:
- Rewrote flake.nix to define package and app outputs for building and running arnis
- Removed flake-utils dependency from flake inputs and lock file
- Added README documentation for running arnis directly via
nix run
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flake.nix | Complete rewrite to add package building with rustPlatform.buildRustPackage, define app outputs, and remove flake-utils dependency |
| flake.lock | Removed flake-utils and systems dependencies to reflect simplified flake inputs |
| README.md | Added command example for running arnis via nix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Owner
|
Sorry for the late follow up and thanks for the contribution! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
The nix flake was oddly written, and it only allowed to enter a development shell.
I rewrote it so it actually builds the package, therefore i added a README entry describing how to run directly the package from nix.
It is still possible to enter a development shell with
nix develop(nix users should know how to do that)Don't hesitate if you have any questions ! And thank you for managing this projet.