Fix spawn point Y coordinate update for longitude values outside ±90°#660
Merged
Fix spawn point Y coordinate update for longitude values outside ±90°#660
Conversation
|
⏱️ Benchmark run finished in 0m 33s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-01-10 12:18:42 UTC You can retrigger the benchmark by commenting |
Co-authored-by: louis-e <[email protected]>
Co-authored-by: louis-e <[email protected]>
Co-authored-by: louis-e <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failed update of spawn point Y coordinate
Fix spawn point Y coordinate update for longitude values outside ±90°
Dec 7, 2025
Owner
|
retrigger-benchmark |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where spawn point Y coordinate updates failed for locations with longitude values exceeding ±90 degrees (e.g., Asia, Pacific regions), causing "Latitude X not in range -90.0..=90.0" validation errors.
Changes:
- Fixed coordinate order in bbox string reconstruction (data_processing.rs) from lng,lat,lng,lat to lat,lng,lat,lng format
- Added clarifying comments explaining the bbox string format requirements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawn point Y coordinate updates were failing with "Latitude X not in range -90.0..=90.0" errors for locations where longitude exceeds ±90 degrees (e.g., Asia, Pacific regions).
Root cause: When reconstructing bbox strings for
LLBBox::from_str(), coordinate accessors were called in wrong order, causing longitude values to be validated as latitude.Change: Swapped accessor order in bbox_string formatting (data_processing.rs:287-290)
This ensures reconstructed bbox strings use the same format as the original GUI input, allowing
LLBBox::from_str()to parse them correctly.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.