Merged
Conversation
benjamin051000
force-pushed
the
separate-gui-logic
branch
2 times, most recently
from
75d9c01 to
c39031b
Compare
benjamin051000
force-pushed
the
separate-gui-logic
branch
from
c39031b to
c2d3bfc
Compare
Owner
|
Good point, the two seperate functions for CLI and GUI were already bothering me - this looks much cleaner. Code looks good to me, were you able to test the GUI? I think you mentioned once that you are only using the CLI - but I'm not sure anymore if that was you or someone else. Otherwise I'll test it real quick :) |
Contributor
Author
|
I actually have the ability to test GUI now! I can't remember if I tested it but I will. |
benjamin051000
force-pushed
the
separate-gui-logic
branch
from
c2d3bfc to
668907a
Compare
Contributor
Author
|
Okay, just ran it (in both CLI and GUI) with 42.335390 -71.041782 42.338166 -71.035280 and it seems to generate fine in both cases! |
benjamin051000
force-pushed
the
separate-gui-logic
branch
from
668907a to
d4b74fc
Compare
Owner
|
Amazing, thanks a lot Benjamin! Sorry for the slight delay, I will merge this asap - not later than tomorrow. Very much appreciated🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.rsis an amalgamation of CLI and GUI code. Separate it out: GUI logic gets its own file since it's several functions. The CLI is one function so it can stay in main I guess.