Minor improvements to farmland code#414
Merged
louis-e merged 3 commits intolouis-e:mainfrom Apr 22, 2025
Merged
Conversation
Oleg4260
commented
Apr 20, 2025
| "farmland" => FARMLAND, | ||
| "farmland" => { | ||
| if args.winter { | ||
| DIRT |
Contributor
Author
There was a problem hiding this comment.
Speaking of this, I intentionally did not place a SNOW_BLOCK here to make the world look a little more realistic, I'm thinking of refactoring the winter mode to remove all the SNOW_BLOCKs and put SNOW_LAYER everywhere. In my opinion, the map should generate in the way to look similar to a normal minecraft world.
Contributor
There was a problem hiding this comment.
I agree with this. We should open a separate discussion on how to implement that, since I imagine you'd do the snow layer last after all the normal blocks are placed... 🤷🏼♂️
Contributor
Author
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Just a small change to the generation of farmlands: