Added ores generation in quarries + other changes#337
Conversation
|
I just added another feature that can be enabled in the settings. It fills the underground space with stone, I think it can be useful for many users, but it also should be disabled by default because it increases generation time significantly. Only applies when terrain is enabled. Also now there's bedrock at level -64 for both modes. |
benjamin051000
left a comment
benjamin051000
left a comment
There was a problem hiding this comment.
I didn't review the JS but it looks fine. The Rust is fine as well but consider using fill_blocks() to make it a little simpler
benjamin051000
left a comment
benjamin051000
left a comment
There was a problem hiding this comment.
Please squash the last commit into the previous one. You can do this with an interactive rebase (git rebase -i HEAD~2). Do either a squash or a fixup on the last one so that the previous 2 commits get combined
|
I am not sure if I did it right, let's just hope I didn't break anything... |
Oleg4260
changed the title
|
Looks like the checking proccess broke for some reason and I can see it in other pull requests as well. Should I do something with it? |
|
See #378 |
|
I'm sorry if this commit wasn't necessary, it's my first time dealing with merge conflicts, should I do something or can the maintainer fix it? |
|
Ok, i think i figured it out. But i feel awkward making a lot of commits |
|
You can squash the extra commits together using But there are loads of commits in main that are typos, merges, not actual changes. So it's probably fine, don't worry about it unless @louis-e says otherwise lol 👍 |
| pub terrain: bool, | ||
|
|
||
| /// Enable filling ground (optional) | ||
| #[arg(long, default_value_t = false, action = clap::ArgAction::SetFalse)] |
There was a problem hiding this comment.
Is setfalse what we want here? I don't think this will ever be true.
|
Hi there, I have to apologize for the long delay - but looks good to me, thanks a lot for your contribution! :) |
3 participants
In my previous pull I only added landuse for quarries and landfills, so there would be stone in quarries, but I did not add ores as said in #330, now I added ores as well
Fixes #330