Change rfd features to enable manual builds on Linux.#127
Merged
louis-e merged 1 commit intolouis-e:mainfrom Jan 3, 2025
Merged
Change rfd features to enable manual builds on Linux.#127louis-e merged 1 commit intolouis-e:mainfrom
louis-e merged 1 commit intolouis-e:mainfrom
Conversation
Contributor
Author
|
Looks like CI jobs have to be approved by the maintainer, makes sense. In the mean time, I'm (slowly) setting up a Windows VM on my laptop to test this change. If someone with Windows could verify it works, that'd be helpful! |
benjamin051000
changed the title
benjamin051000
changed the title
benjamin051000
force-pushed
the
main
branch
2 times, most recently
from
046b297 to
96b652c
Compare
Contributor
Author
|
Looks like it built in CI on my fork: https://github.com/benjamin051000/arnis/actions/runs/12599851589 Testing in a VM to make sure it actually runs now. |
Owner
|
Huge thanks for your effort! Will merge it asap, just checking on a few things regarding the Linux compilation issues |
rfd wasn't building on Linux, since its default features appear to be for Windows. This commit changes them to work on Linux. TODO test on Windows.
Contributor
Author
|
No worries. I look forward to getting this running on Linux 🐧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rfd wasn't building on Linux, since its default features appear to be for Windows. This commit changes them to work on Linux.