Skip to content

Comments

BREAKING CHANGE: cleanup lottie component and remove default styles#992

Merged
matinzd merged 7 commits intomasterfrom
fix/container_props
Apr 15, 2023
Merged

BREAKING CHANGE: cleanup lottie component and remove default styles#992
matinzd merged 7 commits intomasterfrom
fix/container_props

Conversation

@matinzd
Copy link
Member

@matinzd matinzd commented Feb 25, 2023

Rationale

There are a lot of styles being applied behind the scenes resulting in unexpected behaviors.

Solution

Remove the outer layer and pass everything directly to native lottie view

What is changed?

  • Removed using Animated API by default in the source code, fixes (Animate Lottie with react-native-reanimated #1003)
  • Fix resize mode in Android
  • Removed absolute style being applied to the LottieView
  • Removed default aspect ratio styling
  • Removed default width being applied

What actions need to be taken moving forward?

You need to handle everything related to aspect ratio and sizing yourself. The reason for removing all these default values is to avoid confusion when using the library as well as to prevent unexpected behaviors.

Fixes

@matinzd matinzd force-pushed the fix/container_props branch from d6626c1 to 7f9766a Compare April 1, 2023 15:12
@matinzd matinzd changed the title fix: container props and its types (WIP) BREAKING: cleanup lottie component and remove default styles (WIP) Apr 11, 2023
@matinzd matinzd changed the title BREAKING: cleanup lottie component and remove default styles (WIP) BREAKING CHANGE: cleanup lottie component and remove default styles (WIP) Apr 11, 2023
@matinzd matinzd requested review from emilioicai and gpeal April 11, 2023 19:13
@matinzd matinzd marked this pull request as ready for review April 11, 2023 19:13
@matinzd matinzd force-pushed the fix/container_props branch from f4754b7 to fc4d7a5 Compare April 11, 2023 19:18
@matinzd matinzd changed the title BREAKING CHANGE: cleanup lottie component and remove default styles (WIP) BREAKING CHANGE: cleanup lottie component and remove default styles Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants