fixed crash due to unnecessary decref of a borrowed reference in params array handling

lostmsu · lostmsu · commit 74e7d626f2e1 · 2020-06-16T15:13:32.000-07:00
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -375,7 +375,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth
         static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out bool isNewReference)
         {
             isNewReference = false;
-            IntPtr op;
+            IntPtr op;
             // for a params method, we may have a sequence or single/multiple items
             // here we look to see if the item at the paramIndex is there or not
             // and then if it is a sequence itself.
@@ -393,10 +393,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out
                 {
                     isNewReference = true;
                     op = Runtime.PyTuple_GetSlice(args, arrayStart, pyArgCount);
-                    if (item != IntPtr.Zero)
-                    {
-                        Runtime.XDecref(item);
-                    }
                 }
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`375`	`375`	`static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out bool isNewReference)`
`376`	`376`	`{`
`377`	`377`	`isNewReference = false;`
`378`		`- IntPtr op;`
	`378`	`+ IntPtr op;`
`379`	`379`	`// for a params method, we may have a sequence or single/multiple items`
`380`	`380`	`// here we look to see if the item at the paramIndex is there or not`
`381`	`381`	`// and then if it is a sequence itself.`
`@@ -393,10 +393,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out`
`393`	`393`	`{`
`394`	`394`	`isNewReference = true;`
`395`	`395`	`op = Runtime.PyTuple_GetSlice(args, arrayStart, pyArgCount);`
`396`		`- if (item != IntPtr.Zero)`
`397`		`- {`
`398`		`- Runtime.XDecref(item);`
`399`		`- }`
`400`	`396`	`}`
`401`	`397`	`}`
`402`	`398`	`else`