Conversation
* Expand CI matrix to test against Faraday v0, v1 and v2
iMacTia
force-pushed
the
enhance-faraday-support
branch
from
2546a3b to
14a5f80
Compare
The rbx-2 matrix branch has been failing since 0.8.2 (2019). It doesn't make sense to keep testing it, instead we can try Truffleruby which is gaining some traction.
This was referenced Feb 20, 2022
Closed
olleolleolle
approved these changes
Feb 20, 2022
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
An elegant and succinct improvement - the "check if conn.close is available".
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cc @jrochkind
Why
Faraday v2 was recently released, and people have started having issues with upgrading due to the sometimes pretty deep dependency trees in their applications (see lostisland/faraday#1358 (comment)).
octokitis a fairly popular gem that relies onsawyer, which unfortunately has not been updated in a while!This PR aims to provide rolling support to all major faraday versions, from 0.x through 1.x and even the fresh new 2.x 🎉
Once released, this will allow
octokitand other gems to relax their faraday version lock and support the newest major release 🙌Next steps
@technoweenie @pengwynn once this is approved and merged, we'd need a new release of
sawyerin Rubygems.I'm happy for you to do so, but I could also do it myself if you provide me with 2 things: