Remove multipart middleware and all its documentation and tests#1357
Remove multipart middleware and all its documentation and tests#1357olleolleolle merged 3 commits intomainfrom
Conversation
|
Perhaps this could be in UPGRADING.md or something, how to include the new gem in the Gemfile, and how to include the file required. |
olleolleolle
left a comment
There was a problem hiding this comment.
Removal looks ace, I made a note about "perhaps this one is a thing to teach somewhere, for people upgrading".
|
@olleolleolle good point, I agree they deserve their own section for clarity. I've just added that 👍 |
|
@iMacTia @olleolleolle it is listed in the change log of it this expected ? |
|
@ahmedakef that's correct, this change was applied to both version branches. |
|
@iMacTia but isn't this a breaking change ? |
|
@ahmedakef oh no we'd never do that! In #1367 we removed the middleware code from Faraday, but we added both The real breaking change is in 2.0 where we remove those dependencies, which mean you'll now need to manually add them to the Gemfile if you want to use them. In fact, the changelog for 1.9.0 says "Use external multipart and retry middleware", while the one for 2.0 is "Remove multipart middleware and all its documentation and tests". |
|
@iMacTia thank you so much for the explain and I have to fork and change it to this to work: I already solved my problem, just telling you in case it cause problem to others |
|
Ah thanks for reporting this @ahmedakef. |
|
Ah, I see they're referencing it directly here: https://github.com/googleapis/google-api-ruby-client/blob/v0.8-main/lib/google/api_client/request.rb#L326 That feels really wrong, they're completely bypassing the middleware this way and calling it explicitly, it doesn't really make sense... |
Description
Remove multipart middleware and all its documentation and tests.
Multipart middleware has been moved to a separate repo.
Todos
List any remaining work that needs to be done, i.e: