Skip to content

Remove default default_adapter (yes, you read that right)#1354

Merged
iMacTia merged 2 commits intomainfrom
remove-default-adapter
Dec 30, 2021
Merged

Remove default default_adapter (yes, you read that right)#1354
iMacTia merged 2 commits intomainfrom
remove-default-adapter

Conversation

@iMacTia
Copy link
Copy Markdown
Member

@iMacTia iMacTia commented Dec 29, 2021

Description

  • Remove default Faraday.default_adapter value and add exception message with a link to usage documentation.
  • Simplify RackBuilder internal logic and remove #build delegator from Connection (should not be used externally)

Fixes #1352

…age with link to usage documentation.

* Simplify RackBuilder internal logic and remove `#build` delegator from Connection (should not be used externally)
@iMacTia iMacTia requested a review from olleolleolle December 29, 2021 17:22
Copy link
Copy Markdown
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error : no stubbed request for get

2 participants