Default value for exc error#1351
Merged
iMacTia merged 3 commits intolostisland:mainfrom Dec 21, 2021
Merged
Conversation
added 3 commits
December 20, 2021 21:21
in specs we only sets nil, missing default value in specific circumentances raised ArgumentError for Faraday::ConnectionFailed. It was difficult to spot why. I would like to have this change to do not worry about cases like this: https://stackoverflow.com/questions/59176256/unexpected-behaviour-with-faradayconnectionfailed/70427415#70427415
iMacTia
approved these changes
Dec 21, 2021
Member
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
I couldn't find a reason for why the exc parameter was enforced. We may argue it's not a good idea to raise an exception without useful information in it, but going as far as making it manadatory makes testing more complicated than necessary (as this PR shows fixing our own tests).
LGTM 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I would like to introduce default value for
excindef initializeforFaraday::Error.In some cases it is difficult to find the reason on a first spot when doing
raise Faraday::ConnectionFailedbecause it raisesArgumentError. In other cases likeraise Faraday::TimeoutErrorit works becauseFaraday::TimeoutErrorsets default value orexc.Link to related issues if any. (As
Fixes #XXX) - there was no related issue.I found out that someone has been asking why this is happening on Stackoverflow, I spent some time today looking for an answer for myself.
From my perspective introducing default value does not break anything and simplify codebase.
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Optional section
Stackoverflow: https://stackoverflow.com/questions/59176256/unexpected-behaviour-with-faradayconnectionfailed/70427415#70427415