Callable authorizers#1345
Merged
iMacTia merged 4 commits intolostisland:mainfrom Dec 15, 2021
Merged
Conversation
sled
commented
Dec 12, 2021
| else | ||
| value = params.first | ||
| value = value.call if value.is_a?(Proc) | ||
| value = value.call if value.is_a?(Proc) || value.respond_to?(:call) |
Contributor
Author
There was a problem hiding this comment.
The || is on purpose, because checking the ancestors of an object should be faster than looking up a method. This way, there should be no performance penalty on existing code bases which use a proc already.
Member
There was a problem hiding this comment.
Love this attention to performance, thanks for caring and explaining!
olleolleolle
approved these changes
Dec 13, 2021
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Thanks for the neat test-case and implementation!
Co-authored-by: Olle Jonsson <[email protected]>
olleolleolle
approved these changes
Dec 13, 2021
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
iMacTia
approved these changes
Dec 15, 2021
| else | ||
| value = params.first | ||
| value = value.call if value.is_a?(Proc) | ||
| value = value.call if value.is_a?(Proc) || value.respond_to?(:call) |
Member
There was a problem hiding this comment.
Love this attention to performance, thanks for caring and explaining!
jrochkind
pushed a commit
to jrochkind/faraday
that referenced
this pull request
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows callable authorizers to be passed as proposed in #1344