Skip to content

Explain plan for faraday_middleware in UPGRADING.md#1339

Merged
iMacTia merged 2 commits intomainfrom
faraday-middleware-upgrading
Oct 27, 2021
Merged

Explain plan for faraday_middleware in UPGRADING.md#1339
iMacTia merged 2 commits intomainfrom
faraday-middleware-upgrading

Conversation

@iMacTia
Copy link
Copy Markdown
Member

@iMacTia iMacTia commented Oct 27, 2021

Description

Based on feedback from @mattbrictson.

@iMacTia iMacTia requested a review from olleolleolle October 27, 2021 07:59
@iMacTia iMacTia self-assigned this Oct 27, 2021
Comment thread UPGRADING.md Outdated
Comment thread UPGRADING.md Outdated
Comment thread UPGRADING.md Outdated
Copy link
Copy Markdown
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@iMacTia
Copy link
Copy Markdown
Member Author

iMacTia commented Oct 27, 2021

Thanks for the type-checking @olleolleolle 🙇

@iMacTia iMacTia merged commit de1e9f8 into main Oct 27, 2021
@iMacTia iMacTia deleted the faraday-middleware-upgrading branch October 27, 2021 10:31
@mattbrictson
Copy link
Copy Markdown
Contributor

Thanks for this! ❤️

jrochkind pushed a commit to jrochkind/faraday that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants