Skip to content

Add Faraday 1.x examples in authentication.md docs#1320

Merged
olleolleolle merged 1 commit intomainfrom
add-1.x-examples-to-docs
Sep 1, 2021
Merged

Add Faraday 1.x examples in authentication.md docs#1320
olleolleolle merged 1 commit intomainfrom
add-1.x-examples-to-docs

Conversation

@iMacTia
Copy link
Copy Markdown
Member

@iMacTia iMacTia commented Sep 1, 2021

Description

The online documentation describes the behaviour for Faraday 2.x, but most of our users still use Faraday 1.x.
This is causing confusion, so this PR reintroduces examples for Faraday 1.x in the doc to help.

Fixes #1317
Fixes #1314

@iMacTia iMacTia requested a review from olleolleolle September 1, 2021 08:51
@iMacTia iMacTia self-assigned this Sep 1, 2021
Copy link
Copy Markdown
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@olleolleolle olleolleolle merged commit fdf797b into main Sep 1, 2021
@iMacTia iMacTia deleted the add-1.x-examples-to-docs branch September 1, 2021 09:31
@peterberkenbosch
Copy link
Copy Markdown

Great! Thanks @iMacTia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARNING: Faraday::Connection#basic_auth is deprecated Wrong documentation about Authentication Middleware

3 participants