Add latest rubocop and use Ruby 2.6+#1311
Merged
olleolleolle merged 20 commits intomainfrom Aug 17, 2021
Merged
Conversation
olleolleolle
changed the title
olleolleolle
force-pushed
the
add-latest-rubocop-and-use-26
branch
from
c1a52b3 to
1fcfef4
Compare
This commit enables the Naming/InclusiveLanguage rule.
iMacTia
reviewed
Aug 16, 2021
Member
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
Fantastic work @olleolleolle and well done keeping the todo file under control 👏
I just have a question about auto-correctable cops
We are after the side-effect of setting something in the last match, from this "useless" RegExp.
also Performance/RedundantSplitRegexpArgument.
olleolleolle
commented
Aug 16, 2021
| Max: 14 | ||
|
|
||
| # Offense count: 3 | ||
| Style/DocumentDynamicEvalDefinition: |
Member
Author
There was a problem hiding this comment.
I want to talk a bit about this rule, since the fix will have visual impact, and we'd like to pick the nicest alternative.
iMacTia
approved these changes
Aug 16, 2021
Member
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
This is good as is IMO, we can discuss the pending points offline and address in a follow-up
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces the latest RuboCop version, and sets lower bound of Ruby support to 2.6.
This does the absolute minimum, to get it configured.
See #1309
Todos
Additional Notes
We will see if there are many separate steps to take, if we need a big checklist & issues etc.