Skip to content

Remove deprecated Faraday::UploadIO#1307

Merged
iMacTia merged 2 commits intomainfrom
remove-deprecated-upload-io
Aug 14, 2021
Merged

Remove deprecated Faraday::UploadIO#1307
iMacTia merged 2 commits intomainfrom
remove-deprecated-upload-io

Conversation

@iMacTia
Copy link
Copy Markdown
Member

@iMacTia iMacTia commented Aug 14, 2021

Description

This is part of #1302

@iMacTia iMacTia requested a review from olleolleolle August 14, 2021 08:35
Copy link
Copy Markdown
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny and clear fix.

Perhaps this can be connected to the Issue with the quest for Deprecations? The side bar has something for it I think.

Comment thread UPGRADING.md Outdated
Co-authored-by: Olle Jonsson <[email protected]>
@iMacTia iMacTia linked an issue Aug 14, 2021 that may be closed by this pull request
3 tasks
@iMacTia iMacTia removed a link to an issue Aug 14, 2021
3 tasks
@iMacTia
Copy link
Copy Markdown
Member Author

iMacTia commented Aug 14, 2021

Mmmmh I removed the link because it seems it would have closed the issue after merging this.
But that's not what we want as more deprecated methods/classes need to be removed.

@iMacTia iMacTia merged commit ce0fdf8 into main Aug 14, 2021
@iMacTia iMacTia deleted the remove-deprecated-upload-io branch August 14, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants