Upgrade guide for 2.0 says:
All adapters have already been moved out and released as separate gems. They've then been re-added into Faraday's dependencies so that you wouldn't notice.
— https://github.com/lostisland/faraday/blob/565f463fdc324a8a726a099fe85d291b3ebe5fc1/UPGRADING.md
I read this as saying the adapters would be expressed as dependencies of the faraday gem, so they didn't have to be manually added to downstream consumers to keep using them -- "so that you wouldn't notice". Am I misreading/misunderstanding it?
But this does not seem to have been done? They are not dependencies in faraday 2.0?
https://rubygems.org/gems/faraday/versions/2.0.0
I'm not sure if you changed your mind after you wrote the Upgrade guide but didn't update it? Or if you made a mistake? One way or another the upgrade guide should match actual behavior.
The actual situation, where they are not dependencies, means that intermediate gems have to add any adapters they are using into their own dependencies, which in some cases can limit what versions of faraday they can support. If an adapter gem has a gemspec that allows a narrower range of faraday than the intermediate gem previously did, then the intermedia gem adding a dependency to the adapter gem results in reducing the allowable faraday versions supported by the intermediate gem.
If faraday 2.x included the adapter dependencies itself as the Upgrade guide said, this wouldn't be an issue. I liked the plan in the upgrade guide! :)
Upgrade guide for 2.0 says:
— https://github.com/lostisland/faraday/blob/565f463fdc324a8a726a099fe85d291b3ebe5fc1/UPGRADING.md
I read this as saying the adapters would be expressed as dependencies of the faraday gem, so they didn't have to be manually added to downstream consumers to keep using them -- "so that you wouldn't notice". Am I misreading/misunderstanding it?
But this does not seem to have been done? They are not dependencies in faraday 2.0?
https://rubygems.org/gems/faraday/versions/2.0.0
I'm not sure if you changed your mind after you wrote the Upgrade guide but didn't update it? Or if you made a mistake? One way or another the upgrade guide should match actual behavior.
The actual situation, where they are not dependencies, means that intermediate gems have to add any adapters they are using into their own dependencies, which in some cases can limit what versions of faraday they can support. If an adapter gem has a gemspec that allows a narrower range of faraday than the intermediate gem previously did, then the intermedia gem adding a dependency to the adapter gem results in reducing the allowable faraday versions supported by the intermediate gem.
If faraday 2.x included the adapter dependencies itself as the Upgrade guide said, this wouldn't be an issue. I liked the plan in the upgrade guide! :)