fix: restore channel losing sync models pattern, close #1203#1205
fix: restore channel losing sync models pattern, close #1203#1205looplj merged 1 commit intorelease/v0.9.xfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the backend development guidelines to restrict custom code in resolver files and migrates the parseTimeWindow helper to a dedicated helper file. Frontend improvements include enhanced table responsiveness through column width adjustments and sticky action columns. Additionally, the PR updates several Go dependencies and extends the backup restoration logic to support new channel fields. A commented-out code block in the resolver file, left by the code generator, should be removed.
| // !!! WARNING !!! | ||
| // The code below was going to be deleted when updating resolvers. It has been copied here so you have | ||
| // one last chance to move it out of harms way if you want. There are two reasons this happens: | ||
| // - When renaming or deleting a resolver the old code will be put in here. You can safely delete | ||
| // it when you're done. | ||
| // - You have helper methods in this file. Move them out to keep these resolver files clean. | ||
| /* | ||
| func (r *queryResolver) parseTimeWindow(ctx context.Context, timeWindow *string) (since time.Time, applyFilter bool) { | ||
| loc := r.systemService.TimeLocation(ctx) | ||
| period := xtime.GetCalendarPeriods(loc) | ||
| if timeWindow != nil && *timeWindow != "" && *timeWindow != "allTime" { | ||
| applyFilter = true | ||
| switch *timeWindow { | ||
| case "day": | ||
| since = period.Today.Start | ||
| case "week": | ||
| since = period.ThisWeek.Start | ||
| case "month": | ||
| since = period.ThisMonth.Start | ||
| default: | ||
| // Unknown value - default to allTime behavior (no filtering) | ||
| applyFilter = false | ||
| } | ||
| } | ||
| return since, applyFilter | ||
| } | ||
| */ |
There was a problem hiding this comment.
It looks like gqlgen has left behind the parseTimeWindow function that you've correctly moved to dashboard_helpers.go. This commented-out block can now be safely removed to clean up the file.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Uh oh!
There was an error while loading. Please reload this page.