chore(codex): upgrade codex ua version#1151
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update by incrementing the version number for the Codex user agent. This ensures that the application accurately reflects the current version of the Codex CLI it interacts with, maintaining compatibility and correct identification. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the codex_cli_rs version from 0.98.0 to 0.116.0 in llm/transformer/openai/codex/constants.go, affecting both the UserAgent string and the codexDefaultVersion constant. The review suggests an improvement to construct the UserAgent string using the codexDefaultVersion constant to enhance maintainability and prevent inconsistencies.
| // UserAgent keep consistent with Codex CLI. | ||
| UserAgent = "codex_cli_rs/0.98.0 (Mac OS 15.6.1; arm64) iTerm.app/3.6.6" | ||
| codexDefaultVersion = "0.98.0" | ||
| UserAgent = "codex_cli_rs/0.116.0 (Mac OS 15.6.1; arm64) iTerm.app/3.6.6" |
There was a problem hiding this comment.
The codexDefaultVersion is duplicated within the UserAgent string. To improve maintainability and avoid potential inconsistencies, consider constructing the UserAgent string using the codexDefaultVersion constant. This ensures that only one place needs to be updated when the version changes.
| UserAgent = "codex_cli_rs/0.116.0 (Mac OS 15.6.1; arm64) iTerm.app/3.6.6" | |
| UserAgent = "codex_cli_rs/" + codexDefaultVersion + " (Mac OS 15.6.1; arm64) iTerm.app/3.6.6" |
…ase/v0.9.x * 'release/v0.9.x' of github.com:NekoNuo/axonhub: doc: add request processing (looplj#1155) chore(codex): upgrade codex ua version (looplj#1151) chore: update VERSION to v0.9.22 [skip ci] fix: anthropic adaptive thinking effort did not pass to other outbound (looplj#1150) feat: add cli + skill, close looplj#1085 (looplj#1149) chore: add freebsd support to releases (looplj#1146) feat: standardize chart legend lists (looplj#1141)
Uh oh!
There was an error while loading. Please reload this page.