Skip to content

fix(anthropic): panic for some cases, close #1112#1114

Merged
looplj merged 1 commit intorelease/v0.9.xfrom
dev-tmp
Mar 20, 2026
Merged

fix(anthropic): panic for some cases, close #1112#1114
looplj merged 1 commit intorelease/v0.9.xfrom
dev-tmp

Conversation

@looplj
Copy link
Copy Markdown
Owner

@looplj looplj commented Mar 20, 2026 •
edited by devin-ai-integration bot
Loading

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 20, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential panics by improving the robustness of system message conversion for the Anthropic API. It refactors the logic to correctly interpret and transform diverse system message content formats, such as single text strings and arrays of content parts, into the appropriate Anthropic SystemPrompt structure. This ensures that the system can gracefully handle more complex message inputs without unexpected failures.

Highlights

  • System Message Conversion Refactor: Introduced a new helper function systemMessageToParts to standardize the conversion of llm.Message content into Anthropic's SystemPromptPart format, handling both single string and multiple content parts.
  • Enhanced convertToAnthropicSystemPrompt: Refactored the convertToAnthropicSystemPrompt function to leverage the new helper, ensuring correct handling of system messages with MultipleContent and proper aggregation of multiple system/developer messages into Anthropic's MultiplePrompts array.
  • New Test Cases: Added comprehensive test cases to validate the correct conversion of system messages with various content structures, including single and multiple text parts within MultipleContent, and the combination of mixed system messages.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a potential panic in the Anthropic request conversion logic. The introduction of the systemMessageToParts helper function and the refactoring of convertToAnthropicSystemPrompt ensure that system messages with MultipleContent are handled correctly, avoiding nil pointer dereferences. The changes correctly distinguish between single-string and array-based system prompts, preserving the original format where necessary. The accompanying test cases are thorough and validate the new logic for various scenarios, including mixed content types and multiple system messages. Overall, this is a solid fix that improves the robustness of the transformer.

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@looplj looplj merged commit ee2a9f8 into release/v0.9.x Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@looplj