fix(github-copilot): GPT-5.4 should use Responses API#1064
fix(github-copilot): GPT-5.4 should use Responses API#1064looplj merged 1 commit intolooplj:release/v0.9.xfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求重构了 GitHub Copilot 转换器，以通用化 Responses API 的使用。它从“codex 特定”检查转向更灵活的机制，该机制识别需要 Responses API 的模型，包括 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Copilot transformer to correctly route requests for gpt-5.4 to the Responses API. The changes generalize the logic that was previously specific to "codex" models by introducing a configurable map of models that require this API. This refactoring improves extensibility. Key functions and variables have been renamed for better clarity, such as isCodexModel to usesResponsesAPI. The pull request also includes comprehensive unit tests to validate the new logic, ensuring the changes are robust. The overall implementation is clean and enhances the maintainability of the codebase.
imlonghao
force-pushed
the
fix/github-copilot-gpt-5.4
branch
from
a99e280 to
d573e0e
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
这个 PR 的目标是更新 GitHub Copilot 的转换逻辑，使其不再仅限于 codex 模型，而是能够支持使用 Responses API 的新 GPT 模型（如 GPT-5.4 及更高版本）。为此，引入了 usesResponsesAPI 函数来替代原有的 isCodexModel，通过解析模型版本号来判断应使用哪个 API。相关的字段和函数名也进行了重构，使其更具通用性（例如 codexResponses -> responses）。
整体来看，代码变更逻辑清晰，结构良好，并且为新增的逻辑编写了全面的单元测试，确保了功能的正确性。我只有一个关于代码可读性的次要建议。
|
|
||
| // parseModelVersion parses a model version string into major and minor components. | ||
| func parseModelVersion(version string) (major int, minor int, ok bool) { | ||
| parts := strings.SplitN(version, ".", 3) |
There was a problem hiding this comment.
为了提高代码的可读性和健壮性，建议使用 strings.Split() 代替 strings.SplitN()。Split() 会将版本字符串按 . 全部分割，这样代码就不依赖于版本号中点的数量（例如，处理 6.1.2.3 这样的版本），使得意图更清晰，也更符合 Go 的惯例。
| parts := strings.SplitN(version, ".", 3) | |
| parts := strings.Split(version, ".") |
imlonghao
force-pushed
the
fix/github-copilot-gpt-5.4
branch
from
d573e0e to
f426104
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
这个 PR 的主要目标是更新判断何时使用 Responses API 的逻辑，做得很好。代码修改清晰地反映了意图，即除了 "codex" 模型外，还要支持 GPT-5.4 及更高版本的模型。
我发现 parseModelVersion 函数中存在一个关于版本字符串解析的边界情况 bug，并提供了一个修复建议。修复这个问题将使版本解析逻辑更加健壮。
除此之外，代码的重构（例如，将 codexResponses 重命名为 responses）提高了代码的可读性和通用性。相关的测试也写得很好，覆盖了大部分情况。
2 participants
去掉了 codex 关键字
close #1060