You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8fe3190
Browse filesBrowse the repository at this point in the historyBrowse files
fix: four silent-data-loss paths, and make the only real gate run
**A commit could land on a shared repo's default branch after the user declined.**
For an attached member repository `runGitActionWithToast` force-clears
`featureBranch`, but the default-branch dialog still offered "Checkout feature
branch & continue" as its primary button: it re-entered with the flag set, the
flag was cleared, the prompt was suppressed, and the commit landed on the shared
checkout's `main` anyway. The button is now offered only where it can be honoured.
**The repository-ownership guard failed open.** `activeRepo` is null precisely
while the repo list is empty — thread switch, reconnect, project refetch — and
the guard skipped itself there, so a toast follow-up naming a member repo acted
on the thread's own worktree. That is the redirection the comment above it
forbids.
**Selecting vLLM discarded every unrelated setting.** vLLM is `safetensors` and
the model catalog holds only mlx/gguf, so choosing it produced `modelId: ""`,
which `LocalLlmModelConfig` rejects — and because the panel patches `localLlm`
as one whole object, the rejection dropped the entire patch with no error.
Providers with no compatible model are no longer offered, and `onProviderChange`
refuses such a switch as a backstop.
**Applying a local-LLM preset appeared to do nothing, then undid itself.** The
env-var table seeded state from props once; the card is keyed by instance id so
it never remounted. The preset's variables were saved but invisible, and the
next edit republished the stale draft over them. Re-seeding compares by value,
not identity, so our own round-trip and a half-typed row never wipe the draft.
**Git revisions reject a leading `-`.** `git diff --output=<path>` creates and
truncates <path> while parsing arguments, before it fails (verified against git
2.55.0), so unvalidated refs made the read-only review RPCs a file-clobber
primitive. Enforced in the schema so every call site inherits it.
**The pre-push hook now runs the full gate.** `ci.yml` correctly lists `personal`,
but every job asks for `blacksmith-*` runners that exist only in the upstream org,
so jobs queue for 24h and cancel — 429 runs on this fork, zero successes, zero
failures. The hook ran only typecheck+lint on the belief that CI covered the rest.
It never has. AGENTS.md's contradicting claim is corrected.
Also pins the turn-retention window: every case was written as
RETAINED_TURN_ITEMS ± n, so the suite passed for any window and left the one
number the module exists to choose unasserted.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_017aHKjwZuipaALhwguxeRJe
0 commit comments