Skip to content

refactor: Remove Cupertino routing options and update the list of contributors#1076

Merged
GT-610 merged 1 commit intolollipopkit:mainfrom
GT-610:main
Mar 19, 2026
Merged

refactor: Remove Cupertino routing options and update the list of contributors#1076
GT-610 merged 1 commit intolollipopkit:mainfrom
GT-610:main

Conversation

@GT-610
Copy link
Copy Markdown
Collaborator

@GT-610 GT-610 commented Mar 19, 2026 •
edited by coderabbitai bot
Loading

  • Remove code related to Cupertino routing that is no longer in use
  • Update the list of contributors on GitHub
  • Update the version of the xterm submodule

Summary by CodeRabbit

Release Notes

  • New Features

    • Added four new participants to the community contributors list.

  • Improvements

    • Removed iOS routing setting option from application preferences.

  • Chores

    • Updated terminal package dependency to the latest version.

@GT-610
refactor: Remove Cupertino routing options and update the list of con…
fed7ec8 
…tributors

- Remove code related to Cupertino routing that is no longer in use
- Update the list of contributors on GitHub
- Update the version of the xterm submodule
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8c6c8d6f-45ef-4fcb-b8b7-dcea9ad6947f

📥 Commits

Reviewing files that changed from the base of the PR and between f280113 and fed7ec8.

📒 Files selected for processing (4)
  • lib/data/res/github_id.dart
  • lib/data/store/setting.dart
  • lib/view/page/setting/entries/app.dart
  • packages/xterm
💤 Files with no reviewable changes (2)
  • lib/view/page/setting/entries/app.dart
  • lib/data/store/setting.dart
📝 Walkthrough

Walkthrough

This PR modifies three main areas: it updates the GitHub IDs dataset by adding four new participant IDs ('jiao114514jiao', 'jjyou-github', 'yeluonight', 'Yinhono') while maintaining the existing contributor list, removes the deprecated cupertinoRoute property from the settings store and its associated UI component in the app settings page, and updates the packages/xterm submodule to a new commit version.

Possibly related PRs

Suggested reviewers

  • lollipopkit
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing Cupertino routing options and updating the contributor list, both of which are clearly reflected in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from lollipopkit March 19, 2026 07:51
devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@GT-610 GT-610 merged commit e8265bc into lollipopkit:main Mar 19, 2026
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@lollipopkit lollipopkit Awaiting requested review from lollipopkit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GT-610