Skip to content

fix(ssh page): Fix incorrect one-line keys height#1011

Merged
lollipopkit merged 1 commit intolollipopkit:mainfrom
GT-610:fix/one-line-keys
Jan 17, 2026
Merged

fix(ssh page): Fix incorrect one-line keys height#1011
lollipopkit merged 1 commit intolollipopkit:mainfrom
GT-610:fix/one-line-keys

Conversation

@GT-610
Copy link
Copy Markdown
Collaborator

@GT-610 GT-610 commented Jan 17, 2026 •
edited by coderabbitai bot
Loading

Resolve #1009.

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Enhanced virtual keyboard layout to properly adjust key sizing based on orientation mode (horizontal and vertical), improving touch precision and visual balance.

✏️ Tip: You can customize this high-level summary in your review settings.

@GT-610
fix(ssh page): Fix the issue with calculating the height of the virtu…
3f0a47a 
…al keyboard

When the virtual keyboard is arranged horizontally, a fixed height is used; when arranged vertically, the original calculation method is maintained
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 17, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The virtual keyboard key height calculation was updated to use full viewport height when horizontal single-line layout is enabled, versus dividing the height by row count for multi-row layouts. This affects the sizing of individual key items based on the layout orientation mode.

Changes

Cohort / File(s) Summary
SSH Virtual Keyboard Height Calculation
lib/view/page/ssh/page/page.dart		 Modified key item height logic: when _horizonVirtKeys is enabled, uses full _virtKeysHeight; otherwise divides by row count. Affects single-row versus multi-row virtual keyboard layout sizing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing incorrect height calculation for one-line virtual keys to resolve the usability issue.
Linked Issues check ✅ Passed The code change directly addresses the height calculation issue [#1009] causing key labels to collapse in one-line mode by using full height when horizontal layout is enabled.
Out of Scope Changes check ✅ Passed The change is narrowly focused on the virtual keyboard height calculation logic and directly relates to the linked issue; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39a3e08 and 3f0a47a.

📒 Files selected for processing (1)
  • lib/view/page/ssh/page/page.dart
🧰 Additional context used
📓 Path-based instructions (1)
lib/view/**/*.dart

📄 CodeRabbit inference engine (CLAUDE.md)

lib/view/**/*.dart: Prefer widgets/utilities from fl_lib for common UI (e.g., CustomAppBar, context.showRoundDialog, Input, Btnx.cancelOk)
Prefer using libL10n strings before adding new ones to project l10n
Split UI into build, actions, and utils; use extension on to separate concerns

Files:

  • lib/view/page/ssh/page/page.dart
🔇 Additional comments (1)
lib/view/page/ssh/page/page.dart (1)

356-361: LGTM! Fix correctly addresses the one-line virtual keys height issue.

The conditional height calculation now properly uses the full _virtKeysHeight (37px) for horizontal mode, instead of dividing by row count which resulted in collapsed labels. For vertical mode, the original division logic is retained since _virtKeysHeight is pre-multiplied by row count in didChangeDependencies().

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lollipopkit lollipopkit merged commit 7926a4d into lollipopkit:main Jan 17, 2026
2 checks passed
@GT-610 GT-610 deleted the fix/one-line-keys branch January 17, 2026 13:18
@coderabbitai coderabbitai bot mentioned this pull request Jan 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android one line virtual keys unusable

2 participants

@GT-610 @lollipopkit