Skip to content

feat: reasoning content#261

Merged
lollipopkit merged 3 commits intomainfrom
lollipopkit/issue226
Apr 26, 2025
Merged

feat: reasoning content#261
lollipopkit merged 3 commits intomainfrom
lollipopkit/issue226

Conversation

@lollipopkit
Copy link
Copy Markdown
Owner

@lollipopkit lollipopkit commented Apr 26, 2025 •
edited by sourcery-ai bot
Loading

Fixes #226

Summary by Sourcery

Display reasoning steps from the AI model within chat messages.

New Features:

  • Show AI reasoning in an expandable section above the main response.

Enhancements:

  • Refactor Markdown rendering into a reusable widget.
  • Prevent auto-scrolling if the user manually scrolls the chat.

Build:

  • Update dependencies, including openai_dart, fl_lib, extended_image, file_picker, and add webdav_client_plus.

Chores:

  • Add a reasoning field to the chat history data model.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds support for displaying reasoning content in chat history items, updates several dependencies including switching the openai_dart package to a git reference, and makes minor adjustments to the scrolling behavior in the home page.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add support for displaying reasoning content in chat history items.
  • Added a nullable 'reasoning' field to ChatHistoryItem.
  • Updated Hive adapter and JSON serialization to include the 'reasoning' field.
  • Modified ChatHistoryContentView to display reasoning content using an expandable tile.
  • Extracted Markdown rendering logic into a new method.
  • Updated the stream listener to handle and append reasoning content delta.
 lib/data/model/chat/history/history.dart
lib/data/model/chat/history/history.g.dart
lib/data/model/chat/history/view.dart
lib/view/page/home/req.dart
lib/data/model/chat/history/history.ext.dart
Update dependencies and switch openai_dart to a git reference.
  • Updated extended_image and file_picker versions.
  • Changed openai_dart dependency to a git reference.
  • Added webdav_client_plus dependency.
 pubspec.yaml
pubspec.lock
Adjust scrolling logic in the home page controller.
  • Modified auto-scroll behavior to stop if the user has manually scrolled.
  • Inlined the chat scroll listener definition.
 lib/view/page/home/ctrl.dart
lib/view/page/home/var.dart

Assessment against linked issues

Issue Objective Addressed Explanation
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 26, 2025
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lollipopkit - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Extracting the markdown rendering logic into the _buildMarkdown method improves code organization.
  • Consider removing the seemingly accidental 'zagu lollipopkit' text from the comment in lib/view/widget/code.dart.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lollipopkit lollipopkit merged commit 7a7565a into main Apr 26, 2025
1 check passed
@lollipopkit lollipopkit deleted the lollipopkit/issue226 branch April 26, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: reasoning content

1 participant

@lollipopkit