Skip to content

Commit 4d43fcd

Browse files
changed the code the way mysql container is initialized. Trying to fix the issue - feast-dev#4128
Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <[email protected]>
1 parent ed2dd43 commit 4d43fcd

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

‎sdk/python/tests/unit/test_sql_registry.py‎

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from pytest_lazyfixture import lazy_fixture
2222
from testcontainers.core.container import DockerContainer
2323
from testcontainers.core.waiting_utils import wait_for_logs
24-
2524
from feast import FileSource, RequestSource
2625
from feast.data_format import ParquetFormat
2726
from feast.entity import Entity
@@ -84,14 +83,20 @@ def mysql_registry():
8483
container = MySqlContainer("mysql:latest")
8584
container.start()
8685

87-
log_string_to_wait_for = "ready for connections. Version: '8.2.0' socket: '/var/run/mysqld/mysqld.sock' port: 3306 MySQL Community Server - GPL" # noqa: W605
88-
waited = wait_for_logs(
89-
container=container,
90-
predicate=log_string_to_wait_for,
91-
timeout=60,
92-
interval=10,
93-
)
94-
logger.info("Waited for %s seconds until mysql container was up", waited)
86+
# log_string_to_wait_for = "ready for connections. Version: '8.2.0' socket: '/var/run/mysqld/mysqld.sock' port: 3306 MySQL Community Server - GPL" # noqa: W605
87+
# waited = wait_for_logs(
88+
# container=container,
89+
# predicate=log_string_to_wait_for,
90+
# timeout=60,
91+
# interval=10,
92+
# )
93+
94+
## testing for the database to exist.
95+
import sqlalchemy
96+
engine = sqlalchemy.create_engine(container.get_connection_url(), pool_pre_ping=True )
97+
engine.connect()
98+
99+
# logger.info("Waited for %s seconds until mysql container was up", waited)
95100
container_port = container.get_exposed_port(3306)
96101
container_host = container.get_container_host_ip()
97102

0 commit comments

Comments
 (0)