Skip to content

Comments

fixed encryption base64 encoding bug, +random ivs, + cipher reuse#2

Closed
jsvd wants to merge 6 commits intomasterfrom
ivs_cipher_reuse_bugfix
Closed

fixed encryption base64 encoding bug, +random ivs, + cipher reuse#2
jsvd wants to merge 6 commits intomasterfrom
ivs_cipher_reuse_bugfix

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Dec 22, 2014

closes #1

fixed encryption base64 encoding bug
fix for "uninitialized constant LogStash::Filters::Cipher::OpenSSL"
fixed error on nil/blank source field
added support for random iv's
fix hard wired 16 iv length
added max_cipher_reuse to permit re-use of the cipher instance rather than forcing re-creates over and over
@bitsofinfo
Copy link
Contributor

Can this just be merged, then I can re-fork and fix the indentation. Getting confused as to how to properly do it at this point. The commits above seem to reference my orignal PR commits, but when I make an edit there, the latest commit is not showing up (indent fix) bitsofinfo/logstash-contrib@c1d434e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 5 spaces, not space + tab

#     filter ...

@bitsofinfo
Copy link
Contributor

Can someone please give me a tip on where I should make these changes?

My original changes are here: https://github.com/bitsofinfo/logstash-contrib/blob/master/lib/logstash/filters/cipher.rb

Should I just make my changes there, and submit another PR?.... which I don't think will work because these are entirely 2 different projects now...

bitsofinfo added a commit to bitsofinfo/logstash-filter-cipher that referenced this pull request Jan 27, 2015
…gstash-contrib#79

This incorporates those changes plus those requested for the new plugin location at: logstash-plugins#2
@bitsofinfo
Copy link
Contributor

Please close this PR, it is replaced by #3

@jsvd
Copy link
Member Author

jsvd commented Jan 27, 2015

replaced by #3

@jsvd jsvd closed this Jan 27, 2015
@jsvd jsvd deleted the ivs_cipher_reuse_bugfix branch September 4, 2015 09:26
jsvd pushed a commit that referenced this pull request Jan 27, 2016
…gstash-contrib#79

 * plus changes requested for the new plugin location at: #2
 * incorporate PR #7 changes (strict b64 usage)
 * note about JCE policy files, key sizes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any plan to merge outstanding existing pull request before starting yet another project?

3 participants